From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B37C0A04A8; Wed, 26 Jan 2022 15:24:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37FDE42739; Wed, 26 Jan 2022 15:24:18 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id C271B42716 for ; Wed, 26 Jan 2022 15:24:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643207056; x=1674743056; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=2/bPBnQFEsmQ0549MsqMXjVGxDnL618pjnY7FUuZlD4=; b=c8fbcTifu73tKHD2zBrQKAzUhC7f6MuTRhr1fJEOv8XxIZaKvaGc84RP WBaFbmwdudHoJ5J+APTUMVP+Q9MSoTwBNtu3uUtO0vvhmpl+rEyj1vwlo KuKLs5HlOgvRF4ClUw55z+k02vH2IE2SGu/3LbqGFChEfcmO8dindBy9R pw56mpYvquiFWD+DKvP0CW3m5DM6gkVaSzHeRpQ7b6bRGbFqywULVWe0S /Ns/nad+LH4ug5Fk02hcG7PiSp0bkpzFfTtE2GnPXgc3KbxeXRxs/wbn+ P62A3GAMZ27BUBc3TCRCRgNr3Xh7pSLpPYB4PDPJejXI6wtCJfj7OmLy5 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10238"; a="246776613" X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="246776613" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2022 06:24:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,318,1635231600"; d="scan'208";a="628315121" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga004.jf.intel.com with ESMTP; 26 Jan 2022 06:24:15 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 26 Jan 2022 06:24:14 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 26 Jan 2022 06:24:14 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.47) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 26 Jan 2022 06:24:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I0ATASIifuqlBQZMeBthtSwnd+8nGD4XY76pTKjwsf75cm4S896wy7MH4gCrXRozQ+yVtUstQ02rhM7t8WCUF0LRazaydywc/0YjXHe0Fj1fA3Y5OYOKbexWjDm3AosNZtUJB1LyX+czXXIo3ZXB/UEB3FioNBJd3+p9Wx9HVQtQvqS8iaEUQaT00ChdtG7EokVgL4PnM5gxNU/yjvrpCIhW0Ewy5oNCGn1XUs810StJsw1A7serwfgMW0LK0cN1vMDPWG91ic4Y2edfI42xJZqIaPKlBHaEjZotZG0WhY5DHSdf5q8BF/5h8asDTWRtketCvyB9L+wXwp+em6WnDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m4vfI4My60WSOrSnF15XqzvG1ytDD69xMTbEReomIB4=; b=VoyMVSGLrzFmxUYEBk376Z3oQeWS0NK/hCs/72y5f6uBVRr+tr3wfWflSo03Urf273yzJEwNjhULCRk7YitGhbYtaHHD/ZSeZ/DjGo4IfWUg6hV1F7dYrcNWZQD47akePJWTAIOtsHHmn8AjlOeRYa0++hsDAhb3lCiqiPMei2Dwxb7UaopWjvXrTC+h7Dswr+KZnPvsMdFOrFc9gZKJ37LrYqWbt7Pg6sRjy5dzzZwWc7p1ttGqsKaZN3VSpOBPXr/PZtbxFCM33w+S90RSb03ZjFawuKqyOvQlS3Lm6e2T3t9vvJvJNc8RgIBmhsEEGLeFTGLz+ECDrdvsbfvRog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN6PR11MB1715.namprd11.prod.outlook.com (2603:10b6:404:49::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Wed, 26 Jan 2022 14:24:12 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4909.019; Wed, 26 Jan 2022 14:24:12 +0000 Message-ID: <18250b66-2dc5-e6ea-4783-9edbdc747451@intel.com> Date: Wed, 26 Jan 2022 14:24:07 +0000 Subject: Re: [PATCH] net/memif: remove unnecessary rx_intr stub Content-Language: en-US To: =?UTF-8?Q?Morten_Br=c3=b8rup?= , "Stephen Hemminger" , , CC: References: <20220114204644.351712-1-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35D86E07@smartserver.smartshare.dk> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86E07@smartserver.smartshare.dk> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0601CA0033.eurprd06.prod.outlook.com (2603:10a6:4:17::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ec29fa6d-68d3-49ce-1935-08d9e0d7861b X-MS-TrafficTypeDiagnostic: BN6PR11MB1715:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1vkIiwj8J9Q3ZZh7aCcKR+S06X+JtTsOs9WZNe+PD2u4RU0aVLwRbTZBOpssG/hpxVvasqrHngods5JDXIu0vNa9lDmLxh560ZpYqZ+VYnhEj38lwpOWkXEpAUj2Vx9smINaH6n4+4Nv86ysRE+B2WcrGIoUUKKZ82yRzAbF3mh4tuhl2t+f2PmYi8rPRImsP71jrsK6GGsoGjFgqXQsHIAKSRfCYxzibYM3eb+EwCip6xWbeueYYrkxO/L9Bi31tw2Qyk8qdThoiTOYa1DFfNiuLxU8J3i4skuCuuzbvWt73I15nD9pAMeUw1g5AjtAUj/N4iCFqmzZmGGc0fyaHgO+63PfNCivb2hjqd4e3Qc7/QItRJ4JfDuU44oOvmMvjGQeaRNgdO8rHfberdo8j+Nu4NVuaiRuDZutdCNVhU9ivP4D7oIUg9pVtm378k1eBG9EU3j0K8xFRFpl/7KCAGEZD4kkiJGWFDUy9MXdjEavKMoe0GGsWMU7CSyfG+CZmpE2mNlxYDXNKuvogAFUf88/lAbhot7o9jAX/YdqYy8NSENGcN72beA0XnOHN3xGHeLMiUf4v5crIba19pi0hfyGzdn8+7AiptMaDFEMKI4JHBT8uE2fhcNEHhT9+wrqfkrzjxMWqzfDcvzD+FKUrS5W2FfKcOl/U/d3uUVI/sbWhhfd58EHi2MAXF4mOr+2X+ee/sNpYQPahdncT6sSIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6636002)(316002)(36756003)(26005)(110136005)(31696002)(2616005)(186003)(31686004)(82960400001)(38100700002)(2906002)(6486002)(53546011)(4326008)(66946007)(6512007)(44832011)(6666004)(6506007)(86362001)(4744005)(5660300002)(8936002)(8676002)(66556008)(66476007)(508600001)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkk1UlhFL0tURFJ0ZVBENjBwZnRxeGU0NXIrYXF2YXVmTE5FSHlUUEx1cGtX?= =?utf-8?B?eUl0TWhHZ2s3V0xBK0crV2M5TnU2NS9mZEt1cGRWVUhZQU5UUkpZM2pJN2t0?= =?utf-8?B?azh1aG9MWlVXY3B0YWpFYi9ROURQUGhWOVM1bEdoTTJUclRUVFFxQi94TDZu?= =?utf-8?B?ZDNtNU5RYkxXYk9HeEcyZS9vZzlPeEthY25jcmVDeDRHNFJCc0FwYWUvVFkz?= =?utf-8?B?ZVNZUDU3ZWgzbVBNMUp3ZnYrUGV1OURhOFJJclBOYXBYTkt4NkJGdy9WWmM2?= =?utf-8?B?VWNjZnhieVRGemViTnZ6ZjBXcW1seXozNFBDbncrUmVic2xIYy9YcEJERXV0?= =?utf-8?B?N081NEQ3QzkwaWxOWnBOamJ0OW5HdTViRS9rNkxPZmNBOVNKTjUrSFpmdW5H?= =?utf-8?B?WmsraG5LcmpIdzNyaXEwdVpTZnh5S0Ezbll0MnhQYkxmeWswYVZEUjFuU3R3?= =?utf-8?B?QTZHRzVGUlZNTTNQRmNlQW43RGhXYXdmeXV1U3kzTE5QaFBHNDlMdVNmSG91?= =?utf-8?B?alFyb1RINTFqTXpiSXUyTnU1Vm13WkV4c0JsOFdKMGszODJmZXBJNlFvWnVP?= =?utf-8?B?aEx6NHhLZGNYMVBRVSt2c2dSaitGbkRUbmpnTmtJU0ltc3BVK1pTdlY2MTZQ?= =?utf-8?B?TmJ0WENxT2pDd1ZxZ3h0Ny9QR20zOVhhZ1oxZXR5dWdlc3NqRHV0YzFDZC9O?= =?utf-8?B?UzF1ZFZKcTh3NGlWSjBRTWhhL2kzSUVockhGUk5ZdjYvNlE4MDFDcExSMDR2?= =?utf-8?B?d09rYTdIaVNxbVVWVTNLTXdqaWhJWHpCcFJ4TlVLUjV5YkhBZHBNWmY3V0gz?= =?utf-8?B?cGpzM1dpdkJ3ajJEQUZ2Z2dIaVdDZ0k1VjJrVFVmWEVqZGg1MGJnNTNKWW1v?= =?utf-8?B?VGpqWFgyNmI2cVR0MTNpYUJtamxDZ0RmcUhRQ3BzSkh0NmNDeVJVTVJuU1c1?= =?utf-8?B?VkJuWXR1dTgwZ2hOMTMzMlFGaDJjWmtBeTdNSnBLdDZ5TlRQT2FOeElka1Jj?= =?utf-8?B?STZRUi9ab3NmWEdWc2RHU2ovTE94aDIrL2UyWVlnUk9iUUxCN1FrQkhaZ1JW?= =?utf-8?B?ckNtY3RzcmdwV2R6WWFEY3VIYThhcVJQdEN3ay9EQ1FMU0F4TllacEJ5aVBn?= =?utf-8?B?SW9RdjZQT2NrdkZTVE5TaXFBSUI2dUlVODdzM05yK2VKcHZuK3V2ejdkcm14?= =?utf-8?B?bHF6ZzBnUElHS0xFaVp5RnRNSWhkcEU0Q2I5V3RLZ0xWdGhKd0Z4RXU4UlVD?= =?utf-8?B?TG1BOVJva1RPSUJLM3pzZDQwSnNQcXU2SVVKdWpnUGhYcldReWdkaE8vRlZJ?= =?utf-8?B?ZlNyeXBjSzVxRFpseVdqVUZiQWN3czBaS29YWDNrSUtXR01Ec2JXSFdFSjA3?= =?utf-8?B?aVpyTk5rUHV0d1pGNnQ4SThwVVA1Z3M3aGJnQ2xNVWJJOGVPeWc4Q0RxUjk5?= =?utf-8?B?VTE4Yno2R2JaZEVtcG1kc1BMbDRpbUlDY3o3RWpjRmNpWGh2RUh4S0xCMnoz?= =?utf-8?B?S2ZReWd5Ym5mUk1ONzhlMmYzNjgvREtQYUdRT0xIdjJhY00zVTZDdkMzeitZ?= =?utf-8?B?dzJGN3RNZmFwdFA0WEdFcjBpYUgwZ0V3U1Rld255b09QZGRjYjJIdHhyMk9N?= =?utf-8?B?ZkY1RmFIeVF5R3RGOEovdGlUa2JKTWlMSFZ0VTVXNkI0UFBRTkVRaUUvVHND?= =?utf-8?B?SU9LbHAvbnBySkVMOHlUZSt6R01LRHBBWDhrWDlHaUtIV1dWank3Skt3ajg3?= =?utf-8?B?anhIcUJuUWNtTjgrRVRSMUJ0eXlJSWRTdm1JbkhVbkh0Z29pQjh5MEdGZVhl?= =?utf-8?B?SUgxMzZ1elkxb01lTHA3Y2p5TjI4OHF3TnI3SDQ3UFJXaDFIMHJmaXJrZmR3?= =?utf-8?B?dmJHOFhlcERXY2FCdStRK2FDczEvd0g2ZDZDTlJUcTRLeW5Ua2hzOWpMeUdW?= =?utf-8?B?WThkTE9BYXpETU1Pd0V6dnhPWm9QTE4vSFg4cTE0elRXcTJnT2krUjZZeVJl?= =?utf-8?B?WWxlUUxaa21CNmtLSWtLemU5RkZtZkZVNEdZMm8yY2k4NTRqOTJYZXBUZklq?= =?utf-8?B?N3o2SnVjakE5cmIvcXZxNm5qaCtCMlVVTFpxbDR1SlYxRHNMWC9MZU5QL1R5?= =?utf-8?B?Mkt6cTdjZ1dxTjNxZ2JPR1dVMnpidHBHcFlQMEdydUN6aDZjaDJRQ2xjcUl4?= =?utf-8?Q?GPpbG1kBSdXFi/lPoeM3bnc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: ec29fa6d-68d3-49ce-1935-08d9e0d7861b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 14:24:12.4492 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OEDypfv65A80X1mrcglXhkIIvL2ztRsA/dPnCNZzmjjPjKLHPy126sDSWtNzM0x/wzr8V+docb6weJ1FffWBmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1715 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/15/2022 8:15 AM, Morten Brørup wrote: >> From: Stephen Hemminger [mailto:stephen@networkplumber.org] >> Sent: Friday, 14 January 2022 21.47 >> >> The code in memif driver to stub out rx_irq_enable is unnecessary >> and causes different error returns than other drivers. >> The core ethdev code will return -ENOTSUP if the driver has >> a null rx_queue_intr_enable callback. >> >> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") >> Cc: jgrajcia@cisco.com >> Signed-off-by: Stephen Hemminger > > Acked-by: Morten Brørup > No comment from maintainers, hence progressing, Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.