From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2056C42C81; Sat, 10 Jun 2023 20:33:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB2B2410EF; Sat, 10 Jun 2023 20:33:03 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 02A2040DD8 for ; Sat, 10 Jun 2023 20:33:02 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 40EFD5C00A7; Sat, 10 Jun 2023 14:33:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 10 Jun 2023 14:33:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686421982; x=1686508382; bh=N8PoW7vavg9wqwk9335Lwsmowo3Wv9ZLz0R i9tFU8PE=; b=Nt/KiGLN1ENhmxt0MY06teYyeAdI4AcEvzrPx/H88TNbznRkG1I xMfgD9eIo0DiT+P6UmoTJ/kPPSSojTcMQdMnrzCSvbDpwWqheVs76q+YKNYN7M7R gY7mnwGjtwXQUSix9PADokHmQbdhnpxSKtJQuNv6hWuBfcz+qlwX82esVDK5NEUn LAGSNgr3Koax6z+0qcsJ0pTySxmYIVSLYoXw6LZZSIGa0fRy3a1KxzOUooZRgwxc d/mZJ6mCeZ2Vta9UW3Z+eX5lBrGl/j1sK5BybunWOuKjWNPORsnqxVaeNKpbYsEz YsNs0Zxprjhj0y31uifCU+kE9+r9epgvzXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1686421982; x=1686508382; bh=N8PoW7vavg9wqwk9335Lwsmowo3Wv9ZLz0R i9tFU8PE=; b=FIYu2NNYxcE8l+uQfu0ExfWsUyyfamEOevfocDC1omh3V8vgq3I scItMb0YS5nEadxsC4D75+GuXLPnymiBFJICoJaMzKZd6Rollv/KSbrD15VFgm5v jMsynV9cMxB8XsTYhaPVUnDu7vKEf8Np5CJSfcmAyfXPOAmKAHye7RGKHkW5buAB 5BKyT7uCnfGbD6B5szsWCcs7eoNbbYXGZkramKXOsgLJvQaU67Fu41KtBmZSLBw2 8olbNHZBqUqHAjECFXwldZQKYPvAwhAnPfhxC0zFtSnB2f9TpVlGw3SxGb+VbETn EZgEUHFOb9ByeLVysqTBEJNm73vNhD7u/Wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedutddguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 10 Jun 2023 14:33:00 -0400 (EDT) From: Thomas Monjalon To: Randy Schacher , Farah Smith , Shahaji Bhosle , Ajit Khaparde Cc: dev@dpdk.org, david.marchand@redhat.com Subject: Re: [PATCH v3 04/11] net/bnxt: update Truflow core Date: Sat, 10 Jun 2023 20:32:58 +0200 Message-ID: <1826961.atdPhlSkOF@thomas> In-Reply-To: <20230504173612.17696-5-ajit.khaparde@broadcom.com> References: <20230504173612.17696-1-ajit.khaparde@broadcom.com> <20230504173612.17696-5-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/05/2023 19:36, Ajit Khaparde: > From: Randy Schacher > > Update TruFlow core code to: > - Add shared session management > - Add SRAM session management > - Add dynamic TCAM management > - Add shared TCAM session management > - Add Hot Upgrade support > - Update copyright year I suppose you can update the date in the previous patch for the whole driver. Also this patch is removing some blank lines out of Truflow. And I don't understand the need for removing the blank lines before the last #ifdef of the file. More important, you are doing huge update of many different things in one patch. It looks like you don't want the community to follow what you are doing. For info, there are other things to fix in this patchset: Error: Incorrect indent at drivers/net/bnxt/tf_ulp/generic_templates/meson.build rte_flow doc out of sync for bnxt action set_mac_dst action set_mac_src You can run the following script to catch these issues: devtools/check-meson.py devtools/check-doc-vs-code.sh