From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7B1942D09; Tue, 20 Jun 2023 16:41:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A64A9410F6; Tue, 20 Jun 2023 16:41:36 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id B6EBF400D6 for ; Tue, 20 Jun 2023 16:41:35 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5891C5C01B0; Tue, 20 Jun 2023 10:41:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 20 Jun 2023 10:41:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687272095; x=1687358495; bh=iBX1+cMDusVMCcztv3nOYZphWXzBckVC4Wq tK3nvh2Y=; b=oEc1Ohw1NgS4XEoAphai0CF34KFshIdjGeNORDO6E4xxb/gipf6 GX0BGQhzLQDCFnXTm6agARZ+VAw+171JCjGLT6aLzFhHpQlRYw26cieHlW/+knLR 2H92r5qjbeR5sVtuP8bemW5HVnU27Ebj7fhTX6YgivQ+3gWE/Bhfi1taaOMFIgdY hdfeuzoQy2OYiio+EJeP1unG6kyzVpPzek31Y/VuNsNDSssLy0xpNFATQM7TkxdE +kQljzrk+1DB541CBbzM7FJmNf97Ggy6xZ9hajY+RkKGtRFy+tUZmNAjVnfkUqbp 5yt1Fvp1h2xr0D5yXsYngV3bOdXh1gpbGHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687272095; x=1687358495; bh=iBX1+cMDusVMCcztv3nOYZphWXzBckVC4Wq tK3nvh2Y=; b=ZRXaxGm6a2YhngIWL4gF0T5wIPYTJlqq62FtsBMHCghGrb55eBw O1EQjjWXx2MbgiKRxZBYafi4Q9gNUCyxmmYtIdiU8rPZ723zquu+mfMwuqPPzuzC IT+S2mioWB665ZDDYrjiKpi2rllXMr9ftlluXOirAoalwgNLAxYOFMyra/nyrlRU KdbNsp5QDxL0Xqe5A2ZFuonckr9sNDC4KJp5UnSncpX5zN3mMboypubVy+FZGdGd 8vAjN7TFNT1hBov6jMe/m2T/36irHPFTvFnhuMfzpYF3D89PwYXYeW/atrCiKo6A Jsw4VyiRYuJktId89Q0X4MxZYNpMB3+Fv+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefhedgheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeelhfetudetheekffetgeekveeileekueeivdfhffffgeejfeef gfelkeegffejieenucffohhmrghinhepphhrohhofhhpohhinhhtrdgtohhmpdgrrhhmrd gtohhmpdhgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Jun 2023 10:41:33 -0400 (EDT) From: Thomas Monjalon To: "De Lara Guarch, Pablo" , Fangming Fang , "Power, Ciara" , Honnappa Nagarahalli , "Ji, Kai" , Ruifeng Wang , "Mcnamara, John" , Akhil Goyal Cc: "dev@dpdk.org" , "david.marchand@redhat.com" , Jerin Jacob Kollanukkaran , Ashwin Sekhar T K Subject: Re: [EXT] Re: [PATCH v2 8/8] crypto/ipsec_mb: set and use session ID Date: Tue, 20 Jun 2023 16:41:32 +0200 Message-ID: <1827753.atdPhlSkOF@thomas> In-Reply-To: References: <20230421131221.1732314-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/06/2023 11:38, Akhil Goyal: > > > > > > > > > > > > For info, this does not compile with > > > > > > https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__git.gitlab.arm.com_arm-2Dreference-2Dsolutions_ipsec- > > 2Dmb&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DnL7Si2wl_PRwpZ9TWey3e > > u68gBzn7DkPwuqhd6WNyo&m=g7xU0Pucoh3ZqU7RUlw8mhb- > > zlRr9t6XI0UCQi5vEjEfcovdH8kkXIJ_O-_c5zeg&s=J-l3- > > qBNnT5HJ7OGeu5iECPxB1jrpQ5iA01_AOC2Bac&e= > > > > > > because Arm did not merge Intel's code correctly, and > > > > > > imb_set_session() is missing while version is 1.4.0-dev. > > > > > > > > > > > > Anyway I hate this situation having 2 repos for the same thing. > > > > > > Please merge Arm code in the original repository from Intel. > > > > > > > > > > > Is it possible to make Arm repo as main repo and modify DPDK > > > > > documentation, if Intel not agreeing to include Arm code? > > > > > Currently the Arm repo use case is broken. > > > > > If it is not resolved soon, we can submit a patch to revert the > > > > > patch which is breaking compilation. This need to be fixed by RC2. > > > > > > > > It would be better if the original repo can merge Arm changes. We will > > > > keep regular sync with original repo in the current situation, the > > > > next sync will be carried out earlier in Q3. > > > > > > Yes, it is better to keep original repo. But if Intel is not agreeing to it, We may > > > need to find some alternate way to fix it. > > > We need a sync as soon as possible, as with current Arm repo, DPDK > > > compilation is broken. > > > > > > For now, we cannot merge anything in ipsec_mb driver till we fix the > > > compilation With Arm repo - either by Arm repo sync or by reverting the > > > patches. > > > > DPDK is supposed to use stable versions of the library (e.g. releases), not top of > > main branch. > > As described in README https://github.com/intel/intel-ipsec-mb#4-package-content , tip of > > the main is NOT a release software version. > > In case of ARM library clone, it is not clear what the latest stable version is. > > As the Intel library version is bumped in the first stages of development for the > > next release, it is advisable to avoid updating this version in ARM library, until a > > new Intel intel-ipsec-mb version is released. > > For now, the simplest solution is to revert the ARM library version to 1.3 > > (changing IMB_VERSION_NUM and IMB_VERSION_STR), until the ARM repo is > > synced to Intel 1.4.0 (which has just been released). > > > Hi Pablo, > > The point of discussion here is to have a common repo for both Intel and Arm. > We would have less control if there are 2 repos for same stuff. > The point is if Intel is not willing to take Arm changes in the repo (preferred solution), > Why not update documentation to make Arm one as default which is a > super set of Intel and Arm repo? This will avoid problems going forward. Pablo, how can we reconcile both projects in one repository please?