From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 55E5611F5 for ; Wed, 18 Nov 2015 19:57:40 +0100 (CET) Received: by wmww144 with SMTP id w144so85593936wmw.0 for ; Wed, 18 Nov 2015 10:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=nYhkyWcoAdaFv9NIKBeEe/exobdn4nkP7eC/0LyfW6g=; b=KdO3zBrjDrgo94f9RPJCJTw9n9z3wMycKpJMn2/g7Ca/X70kaRRqrMmFAyThuH7mzq QwZ6O8a0BZWdhQLE8L6HzEd7H9PFKnb3EV54DxifclWM3lbq1rXqT81bSuLBzv+As9oP cTH8rR+3OpCIFt1c7I8v0ChjHWijwT7bIkHz/rxH64MFOPm73Wn9YPi1cIGYboapYCjy rGxlZlE3SwaHYV6GMZlJ1lk6Eytx8vTWzVWgDUuXz8JNYTQTFCEFSKM62P62e4nyrJ4s X11VZXIhurSekeyCq/Y32YGmX5iDXQwuY2WH9dtsJOTXKJyu7CSHSNxiQoLozBbyA7PZ pGdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=nYhkyWcoAdaFv9NIKBeEe/exobdn4nkP7eC/0LyfW6g=; b=Z8X+UZGeZn1KdzTS/Q8BFFsDQeuvgvxUgsvQLZATQ+9BokfeqL0PdQuswob0tkw5vf 8/8e8CRQt93dzCF5tXqSK7khy3R5hLIBOZAzHR0SCCGyeAQXMinG9CvYtsuzaPKuKOL0 5axpfPoJCP/QB8hltxaDIOK86ikLzB37fiZ/aHEGqUflep7Wa3nBV0qu3gS9+PecfmHy jqlCj8JtNhX/yFVCdfQif0/et4mGu8uAFeGkGzo+0vnJKt5rGIKkzLYY15GhvL2JGqGL sSrER7idoSnVtm0xGnXHLyylb945NRyF3hJIVYW9jqHgJwMRFojCEYz/L6vTMURnfWeL lAoA== X-Gm-Message-State: ALoCoQnJnMcnKvHqdjHOOqffI0xE5AR0+v1UsvymPIDzdFHFbfd7H96oe/oFJbXUOuyhk0yM4VyS X-Received: by 10.28.87.72 with SMTP id l69mr5650690wmb.70.1447873060148; Wed, 18 Nov 2015 10:57:40 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id v196sm4626199wmv.10.2015.11.18.10.57.38 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 18 Nov 2015 10:57:39 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Date: Wed, 18 Nov 2015 19:56:25 +0100 Message-ID: <1827952.FiSe5LrlIQ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446802833-22265-7-git-send-email-jerin.jacob@caviumnetworks.com> References: <1446802833-22265-1-git-send-email-jerin.jacob@caviumnetworks.com> <1446802833-22265-7-git-send-email-jerin.jacob@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 06/14] eal: arm: ret_vector.h improvements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Nov 2015 18:57:40 -0000 2015-11-06 15:10, Jerin Jacob: > added the definition of rte_xmm and xmm_t for acl noen implementation. > removed the emulated _mm_* functions 2 nits: - noen -> neon - this kind of change deserves more explanations > +#include "arm_neon.h" I think it should be It won't block the merge of this patch, but as you are becoming the ARMv8 maintainer, please try to check even minor things which make read of DPDK code and history easier.