From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id E9A425921 for ; Mon, 20 Apr 2015 17:00:43 +0200 (CEST) Received: by wgso17 with SMTP id o17so182552854wgs.1 for ; Mon, 20 Apr 2015 08:00:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=o9ZQ+tiXNgooky6ivOZb8dNGAk231IBDwTFemKDZYcA=; b=DwiAb7mlxFG85fg3OD6S5erPFEvvN0OtqxkpUm9VQdlVGQVzSNTdkw5S0yXGwUWbI+ niXmGF3bma4UDwBoDfp5XRCqjEE7M43f/2NpAJ5mxs60FddeuupUlAccyx1ESENktz8q cmZjdblRAMmeUquPewCQQNB6IW6WxysmK99IN9uPK6f7hMrLgfSizOuGiNPgWRQ7iZYa jQiZEuq5oEzlQ1WKdv/PVn6FdutprG6UDJr1YASGz9tGhL/md9FF+LE4562uGDlBPba6 ehlDDjB4mj8afEczn/+k8TBfoLF+crGUc1NDqPmvTP7wx98bdzIpcK0fK82qWWSw8fwh TQIg== X-Gm-Message-State: ALoCoQlyMe3XypHV28jYJE2jImFybDpBpAlHlDRE48sJSROYLhWCQbGUBlaPhxHxGQDfVH50m0rj X-Received: by 10.180.73.180 with SMTP id m20mr26038483wiv.2.1429542043761; Mon, 20 Apr 2015 08:00:43 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id az2sm27631569wjb.4.2015.04.20.08.00.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2015 08:00:42 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" Date: Mon, 20 Apr 2015 16:59:59 +0200 Message-ID: <1828887.OHa7Y3J5bx@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8BFFDF1@SHSMSX104.ccr.corp.intel.com> References: <1429539103-15885-1-git-send-email-thomas.monjalon@6wind.com> <9BB6961774997848B5B42BEC655768F8BFFDF1@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [RFC PATCH] ethdev: remove old flow director API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 15:00:44 -0000 2015-04-20 14:32, Wu, Jingjing: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > It's time to remove this old API. > > It seems some work is still needed to rely only on eth_ctrl API. > > At least ixgbe, i40e and testpmd must be fixed. > > Jingjing, do you think it's possible to remove all these structures > > from rte_ethdev.h? > > > [Wu, Jingjing] Yes, I agree. > But few comments list below. > Beside the following change, some commands also need to be removed in testpmd. For the ixgbe, code to the old APIs are already fixed. > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -672,42 +672,6 @@ struct rte_eth_pfc_conf { > > }; > > > > /** > > - * Memory space that can be configured to store Flow Director filters > > - * in the board memory. > > - */ > > -enum rte_fdir_pballoc_type { > > - RTE_FDIR_PBALLOC_64K = 0, /**< 64k. */ > > - RTE_FDIR_PBALLOC_128K, /**< 128k. */ > > - RTE_FDIR_PBALLOC_256K, /**< 256k. */ > > -}; This is hardware-related. Why should it be part of the API? > > - > > -/** > > - * Select report mode of FDIR hash information in RX descriptors. > > - */ > > -enum rte_fdir_status_mode { > > - RTE_FDIR_NO_REPORT_STATUS = 0, /**< Never report FDIR hash. */ > > - RTE_FDIR_REPORT_STATUS, /**< Only report FDIR hash for matching pkts. */ > > - RTE_FDIR_REPORT_STATUS_ALWAYS, /**< Always report FDIR hash. */ > > -}; > > - > > -/** > > - * A structure used to configure the Flow Director (FDIR) feature > > - * of an Ethernet port. > > - * > > - * If mode is RTE_FDIR_DISABLE, the pballoc value is ignored. > > - */ > > -struct rte_fdir_conf { > > - enum rte_fdir_mode mode; /**< Flow Director mode. */ > > - enum rte_fdir_pballoc_type pballoc; /**< Space for FDIR filters. */ > > - enum rte_fdir_status_mode status; /**< How to report FDIR hash. */ > > - /** RX queue of packets matching a "drop" filter in perfect mode. */ > > - uint8_t drop_queue; > > - struct rte_eth_fdir_masks mask; > > - struct rte_eth_fdir_flex_conf flex_conf; > > - /**< Flex payload configuration. */ > > -}; > > - > [Wu, Jingjing] This structures and above types are useful about global configuration. They can't be removed. Why? I thought eth_ctrl API would be enough. It seems strange to have a part of the flow director API in rte_eth_ctrl.h and another part in rte_ethdev.h. Other filters have no impact on rte_ethdev.h.