From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF4D6A0553; Mon, 17 Feb 2020 16:15:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D9B31DA9E; Mon, 17 Feb 2020 16:15:41 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BF09A1D9C3 for ; Mon, 17 Feb 2020 16:15:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2464221F76; Mon, 17 Feb 2020 10:15:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 17 Feb 2020 10:15:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ZLGC1D059XrhEfyuDdPnzblFiDj2y/KTyF1cazcp8/E=; b=gJcqEdWqvmI7 xPFryObz7bNzqcW2zECIhhnplKAKiJTrbRBJqr/1a/OAbU8IS/EwKC/H0/KTbZk4 +PTyydlhaZbOuRbRtXh65d3OMd7gQLj/51zCpE0DswJun6rMrklf835hKZXZj1an 94wPfvbeAGArNKxFrQ77rUh+nwol3gQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=ZLGC1D059XrhEfyuDdPnzblFiDj2y/KTyF1cazcp8 /E=; b=odd/B316/Iurtw++xDng/6/Ll9ZZwIgyYks2gVUEHFjLH+8AcJpu73Fpw pByX+SXc7pksqP1i2iaxrn3R/J73NM79kMBZeoeHouDHBL1f7QqUdQtZdJlyvujH fhGuhnb1gzGvWY7NorzeP8Kt1yNhZQByZ1G2XF/y3fnhZIIkH0CtS9JyFAZgXD2a 50DjcqSCBgIZhciuGxL2yR+gcwBulgK5X6j4t6eXWZ5puiN+Cqwxge8UazJsAtOO yMus/FVvFFMr5dN0Nt5QWhSezs9Q9sVN2twsjBeeIxV/d6SMXKmtSSz6rpqAk+zR m5FOOfr1HML20gSEDPPBgsSaxu5Qw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrjeeigdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepthhrrghvihhsqdgtihdrtghomhdpshhouhhrtggvfigrrhgvrdhorhhgpdhl rghunhgthhhprggurdhnvghtnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshes mhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 65F0B3060D1A; Mon, 17 Feb 2020 10:15:37 -0500 (EST) From: Thomas Monjalon To: David Marchand , christian.ehrhardt@canonical.com Cc: dev@dpdk.org, dodji@redhat.com, Aaron Conole , Michael Santana , kevin.laatz@intel.com Date: Mon, 17 Feb 2020 16:15:36 +0100 Message-ID: <1829806.xz2uEaWSZ7@xps> In-Reply-To: <20200217135929.30987-1-david.marchand@redhat.com> References: <20200217135929.30987-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ci: build and use libabigail 1.6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/02/2020 14:59, David Marchand: > libabigail 1.2 (at least) reports changes in 'const' property as an ABI > breakage [1]. > This was fixed upstream in libabigail 1.4 [2], and a bug has been opened > in launchpad [3]. > > But for now, build and use the last version 1.6 so that the ABI checks > can be kept. > > 1: https://travis-ci.com/DPDK/dpdk/jobs/287872118#L2242 > 2: https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commitdiff;h=215b7eb4fe8b986fe1cc87d9d8e7412998038392 > 3: https://bugs.launchpad.net/ubuntu/+source/libabigail/+bug/1863607 > > Signed-off-by: David Marchand > --- > + LIBABIGAIL_REPO=${LIBABIGAIL_REPO:-https://sourceware.org/git/libabigail.git} > + LIBABIGAIL_VERSION=${LIBABIGAIL_VERSION:-libabigail-1.6} > + > + if [ "$(cat libabigail/VERSION 2>/dev/null)" != "$LIBABIGAIL_VERSION" ]; then > + rm -rf libabigail > + # if we change libabigail, invalidate existing abi cache > + rm -rf reference > + fi > + > + if [ ! -d libabigail ]; then > + git clone --single-branch -b $LIBABIGAIL_VERSION $LIBABIGAIL_REPO libabigail/src > + cd libabigail/src && autoconf -vfi && cd - > + mkdir libabigail/src/build > + cd libabigail/src/build && ../configure --prefix=$(pwd)/libabigail && cd - > + make -C libabigail/src/build all install > + > + rm -rf libabigail/src > + echo $LIBABIGAIL_VERSION > libabigail/VERSION > + fi Can we avoid compiling libabigail ourself? Is there an up-to-date Ubuntu package somewhere?