From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 772E05921 for ; Fri, 10 Jul 2015 00:52:49 +0200 (CEST) Received: by wiga1 with SMTP id a1so1094923wig.0 for ; Thu, 09 Jul 2015 15:52:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=23aX77nj3rKeyRdm8CXv8F4HmBQArnuuYrUx9+WMV5s=; b=QFZQ5V56wFZB6kRRfEpBaSiiJp+cDgLr+cP4E6COZxyyvj7+RdJ6dcbDbSBmc4sj/L r99bvr20q0Mqn4aH+jElcQ+FdozfuSmNcb4zdbkNK6mZC9H3Fq8azV9rTfdOrmhyiRD/ E9k8Zr6eAXLC6Ok6sJBX88aiwjMGJnnuQZgeIHCUp65+Wg8coMTIp5y7EoQ3uStJenjX rpNvqx3P2gS/5KGf0/hXmmEFx2I0mQkLdZrhofEMfmkS/P+yxuuUpRqwPfxbDwNR5yvA nV+jrul671wi6PQ0nidz+U+K5ahvoohosClF2SJg1Efye2xX5+7WYYZltji24j/TwMEt KS/A== X-Gm-Message-State: ALoCoQlSp/YolVR5yENhHHiAj/AozsioakrA3Biwm17Du6VFBsNQgXYugrD1Q6Nk1ySOi7sjzBp2 X-Received: by 10.194.79.225 with SMTP id m1mr35364709wjx.8.1436482369368; Thu, 09 Jul 2015 15:52:49 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id fo17sm10850238wjc.46.2015.07.09.15.52.47 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Jul 2015 15:52:48 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Fri, 10 Jul 2015 00:51:42 +0200 Message-ID: <1830896.dtZQMEj4sb@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323714E9@IRSMSX108.ger.corp.intel.com> References: <1432750217-4186-1-git-send-email-stephen@networkplumber.org> <1432750217-4186-6-git-send-email-stephen@networkplumber.org> <3EB4FA525960D640B5BDFFD6A3D89126323714E9@IRSMSX108.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 5/5] rte_sched: allow reading without clearing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 22:52:49 -0000 2015-06-04 17:48, Dumitrescu, Cristian: > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > The rte_sched statistics API should allow reading statistics without > > clearing. Make auto-clear optional. In this version, this is handled > > by deprecating the old API and adding a new one. > > > > Signed-off-by: Stephen Hemminger [...] > > --- a/lib/librte_sched/rte_sched_version.map > > +++ b/lib/librte_sched/rte_sched_version.map > > @@ -14,8 +14,10 @@ DPDK_2.0 { > > rte_sched_port_enqueue; > > rte_sched_port_free; > > rte_sched_port_get_memory_footprint; > > + rte_sched_queue_stats; > > rte_sched_queue_read_stats; > > rte_sched_subport_config; > > + rte_sched_subport_stats; > > rte_sched_subport_read_stats; > > rte_sched_port_pkt_write; > > rte_sched_port_pkt_read_tree_path; > > If we plan to obsolete API function rte_sched_queue_read_stats() and have people use the new API function rte_sched_queue_stats(), we should replace every usage of the obsolete function with call to new function. We need to do this in examples/qos_sched and app/test. Patchwork status is now "Changes requested".