From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 68D9B9AA2
 for <dev@dpdk.org>; Fri, 13 May 2016 17:37:56 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id g17so36552142wme.1
 for <dev@dpdk.org>; Fri, 13 May 2016 08:37:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jle4+CMOpQ6GvZlxOGzFu8YNonqZxH8dWYvdFqgGgpA=;
 b=zmQLbiljQCV6LuJtk+tHM8sGxmu6ygCCEaTRdI8MPc4pFjzwutBowaCTb9MAr0O/Oq
 fQV3FAuLLtfM7YXxorERVJWhcHakrNaIZqvXsiIMOVhL3RO0sKLnCXkDXZbBiFjFl86P
 +EqhPe5PwItZwe5ydekKsF1uEgNIKS12UJKrt+UaYtqw6Ki17m+es5NNnijs/KIIxCyK
 oGC8a354tWqS7MaTFDIK07EQUXlUMUHCz//dHVg8rDcPdJaPV3WsO3uooFDJykoMb91v
 +bixXH0tEcmFsB+xQmThvUsbmkRfroh1wwdjpXyYiWrfitgwE8OaAYWTADbFsD127PJq
 nv5g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=jle4+CMOpQ6GvZlxOGzFu8YNonqZxH8dWYvdFqgGgpA=;
 b=mWdbeKfa1g2jUi+Dj76BBJgZ6uVkMavX0VvvCTo65/eLPbwxRnvmzjjrZ8qqz2+hFA
 o8JVv5W6HGK4WtmCyCgYk0gAm3IXuuj/qnPd4ujMaGsMF1AEZTtgXW1W5UrjrrFyu+5J
 vECbaE+wEDHjNka6j/Dw+7akIe4/8tCyERoKSWBV9yhu/YNgrxNSnVzSGOuN1XSEbUYk
 yfm4gptWM3EQbtNLmztxtOR7SmvbH7CTZEW9P36DBnLthV+DiTxp3DK8U1WwM2PVqRMI
 +bgspksWuLcJsabf/t6bZAye1ZbBRBaj0rBqfCl5FCLOXaEWwT6KqFrpHg9KjIqVzbu8
 zTLQ==
X-Gm-Message-State: AOPr4FXjdKdxeXgcnT1O2lLKdyXJyGKQlotgDK11sfrq17M3pDr1GU/soq4A+xjzu50YLVSL
X-Received: by 10.28.4.149 with SMTP id 143mr4247299wme.44.1463153876235;
 Fri, 13 May 2016 08:37:56 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id ck9sm19230982wjc.22.2016.05.13.08.37.55
 (version=TLSv1/SSLv3 cipher=OTHER);
 Fri, 13 May 2016 08:37:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>, rasesh.mody@qlogic.com
Cc: dev@dpdk.org
Date: Fri, 13 May 2016 17:37:54 +0200
Message-ID: <1831204.vI4CoI6YQS@xps13>
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <bf736eb9491042b119d18c1401f7563b400e1e59.1462874485.git.pmatilai@redhat.com>
References: <bf736eb9491042b119d18c1401f7563b400e1e59.1462874485.git.pmatilai@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] qede: fix build with gcc >= 6.0
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 May 2016 15:37:56 -0000

2016-05-10 13:01, Panu Matilainen:
> With gcc >= 6.0, qede base driver fails to build with:
> drivers/net/qede/base/ecore_cxt.c: In function 'ecore_cdu_init_common':
> cc1: error: left shift of negative value [-Werror=shift-negative-value]
> 
> Since the base drivers are untouchable, work around by disabling
> the warning.

Are the qede base driver files untouchable?

> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
[...]
> +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
> +CFLAGS_BASE_DRIVER += -Wno-shift-negative-value
> +endif

Fixes: ec94dbc57362 ("qede: add base driver")

Applied, thanks

Rasesh, would you mind to fix the base driver and remove this workaround?