From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 0EA3BC4F4
 for <dev@dpdk.org>; Tue, 28 Jul 2015 15:49:14 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so180445581wic.0
 for <dev@dpdk.org>; Tue, 28 Jul 2015 06:49:13 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=OLDnaVH8iYZK7wA+MijerthFOPuRIgrqNyltveNg3WA=;
 b=bbfZyLxG3yyRFHBlNKy84xTsJHkzKci/IE5o0XczhFhrDncWEPdgMa+0HODKPMmpzy
 9w5/rNCfatKIUfqz1Z5yFz+r9qDZTpvuIGYfd5/WWxVmq3Z+qiOtHESiQgv1MaYKa1Kk
 bNAifjsW6N7nO/NIs9pNY4SzgKJHNKFAdJJVQBdk17rLQizp8pNKHm1Q3YAbgbBQF2BC
 jDPrBzuwZwr5sqC4Tv7qichO7GhCofrXVXMqcmhaNebZEB3ak9Q6pvQb+0r7GxR9xo9L
 x5BRpwwiMnigdNbVAXzyGeojDDluRbtcfHYrpK7Av0S8QR2IesIAidXZSYYkbVVaSA1o
 sw6Q==
X-Gm-Message-State: ALoCoQmZKO9FGjm5HrKMv1kEr8KP0bMrJVRBNvpO9QRPRWhw8JW+fGi8Hy8IGXsXN2D439Lg6qUE
X-Received: by 10.180.83.72 with SMTP id o8mr35289619wiy.27.1438091353791;
 Tue, 28 Jul 2015 06:49:13 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210])
 by smtp.gmail.com with ESMTPSA id ev2sm19136935wib.21.2015.07.28.06.49.12
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 28 Jul 2015 06:49:12 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Vladimir Medvedkin <medvedkinv@gmail.com>
Date: Tue, 28 Jul 2015 15:47:57 +0200
Message-ID: <1831659.nSDl63dTav@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com>
References: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Make the thash library arch-independent
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2015 13:49:14 -0000

Hi Vladimir,
Thanks for fixing.
Comments below.

2015-07-28 09:06, Vladimir Medvedkin:
> Signed-off-by: Vladimir Medvedkin <medvedkinv@gmail.com>

Please explain how it was broken and how you fixed it.
It would be interesting to know which part is __SSE3__ and __SSE__.

> +#ifdef __SSE3__
> +#include <rte_vect.h>
> +#endif /* __SSE3__ */

Comments after short ifdef block are not needed.

> +#ifndef XMM_SIZE
> +#define XMM_SIZE	16

Why is it needed?