DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5
@ 2015-02-19 10:25 Panu Matilainen
  2015-02-19 10:25 ` [dpdk-dev] [PATCH] i40e: " Panu Matilainen
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Panu Matilainen @ 2015-02-19 10:25 UTC (permalink / raw)
  To: dev

Add extra parenthesis to remove ambiguity on what we want to compare,
otherwise gcc 5 issues a "logical not is only applied to the left hand
side of comparison" warning which with -Werror fails the build.

Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
---
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
index 37e5bae..93a6a00 100644
--- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
+++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_common.c
@@ -2898,8 +2898,8 @@ STATIC s32 ixgbe_fc_autoneg_fiber(struct ixgbe_hw *hw)
 	 */
 
 	linkstat = IXGBE_READ_REG(hw, IXGBE_PCS1GLSTA);
-	if ((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE) == 0) ||
-	    (!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT) == 1)) {
+	if (((!!(linkstat & IXGBE_PCS1GLSTA_AN_COMPLETE)) == 0) ||
+	    ((!!(linkstat & IXGBE_PCS1GLSTA_AN_TIMED_OUT)) == 1)) {
 		ERROR_REPORT1(IXGBE_ERROR_POLLING,
 			     "Auto-Negotiation did not complete or timed out");
 		goto out;
-- 
2.1.0

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2015-02-25 15:26 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-19 10:25 [dpdk-dev] [PATCH] ixgbe: fix build with gcc 5 Panu Matilainen
2015-02-19 10:25 ` [dpdk-dev] [PATCH] i40e: " Panu Matilainen
2015-02-19 11:05   ` Ananyev, Konstantin
2015-02-19 11:09     ` Panu Matilainen
2015-02-19 11:21   ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-02-19 11:41     ` Ananyev, Konstantin
2015-02-20 14:11       ` Thomas Monjalon
2015-02-19 12:02 ` [dpdk-dev] [PATCH] ixgbe: " Ananyev, Konstantin
2015-02-19 12:37   ` Panu Matilainen
2015-02-19 13:07   ` Neil Horman
2015-02-24 13:13 ` [dpdk-dev] [PATCH v2] " Panu Matilainen
2015-02-24 13:45   ` Ananyev, Konstantin
2015-02-25 15:26     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).