From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38805A0547; Thu, 22 Jul 2021 16:10:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AED0C4014D; Thu, 22 Jul 2021 16:10:14 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 4813740040; Thu, 22 Jul 2021 16:10:13 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E2D6E5C014F; Thu, 22 Jul 2021 10:10:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 22 Jul 2021 10:10:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= f9a7EGDIKyK05Mg16aPejHiy1ydjXQ75qfm1p57Dm/E=; b=jb0rWrkt5xANDDqu 7ehG40RS1QOdaDJYw7Exe80oEmtRa1hwOS44I9yQRJ1WPuG1xPzJSVUcke5U54ic f9qYM8e80SwHeOQfslFRE6hd4yeL/bW/OCpvR4wQ3oBoFVkDkzd0SOwhat8W8z6L t9lufmcjQ4+rn7v4h7nmSyYQ8+H/lHq2i0Bq0Gk8ps34UKPu6w51bLE6Szgjo/dX eiRk0kKy7Xkv+UBNzRcWtbAxel1PNr4/co6Pr4g3206iUniApaGDzYGGWPus7Vpd HYE90uiRU0TSQCRuj1HzutO+px8oJkle5pJr8mm3MN+zjoUklgAlXtAWLvHcK23/ e6ZwUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=f9a7EGDIKyK05Mg16aPejHiy1ydjXQ75qfm1p57Dm /E=; b=TPUBShYcAd7QBnE/YCXMh19S1NaoUr4zhIUgTwmWvClp4sNcylyyO/x3s 2SNgoomtkEVu9kXkNz9zxQaGIjFHGehDSD+0ujJbBFukUdaxDLmEYg0+lA7HJsJL G/laWLDMzdrgkmlNvlb5uTFlDzqg4TKrT1deM4F+ycY4QwGRKwEvLKIuDQLSg09Z 85p4gF7JL2TJ0LKC5x2Id94iA8ouNAU9++8poSaWeFgZ2BvsEbhueYxLyCdBkGy5 DANO7weSuAd81rCM64fpUFeATB2/xv8b0SZMVTldOWEEu5gLaZLe8GQ+qU6EYlSP kv9laSvgEiNXnLxLebTkfLtyTAqvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigdejudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdr nhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 10:10:11 -0400 (EDT) From: Thomas Monjalon To: Yunjian Wang Cc: dev@dpdk.org, matan@nvidia.com, shahafs@nvidia.com, viacheslavo@nvidia.com, dingxiaoxiong@huawei.com, stable@dpdk.org, xuemingl@nvidia.com, asafp@nvidia.com Date: Thu, 22 Jul 2021 16:10:28 +0200 Message-ID: <1834160.FsaEv4fRmD@thomas> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix use after free in mlx5_dma_unmap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/07/2021 12:35, wangyunjian: > From: Yunjian Wang > > This patch fixes the use-after-free bug which was reported by Coverity > Scan in the mlx5_dma_unmap function. > > Coverity issue: 371679 > Fixes: 992e6df3dafe ("common/mlx5: free MR resource on device DMA unmap") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang > --- > LIST_REMOVE(mr, mr); > - mlx5_mr_free(mr, sh->share_cache.dereg_mr_cb); > DRV_LOG(DEBUG, "port %u remove MR(%p) from list", dev->data->port_id, > (void *)mr); > + mlx5_mr_free(mr, sh->share_cache.dereg_mr_cb); > mlx5_mr_rebuild_cache(&sh->share_cache); Sorry, it seems this fix has been integrated as part of this patch (for no good reason): https://git.dpdk.org/dpdk/commit/?id=a7f34989e9