From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id CAEC21B705 for ; Tue, 24 Oct 2017 02:15:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 72E5320AEA; Mon, 23 Oct 2017 20:15:51 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 23 Oct 2017 20:15:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Bzi2xeubX8MlqmqEvR0nJGejo9 1VSHTjaDrI/kVJWCY=; b=Y86z6zgb2A5i6vmHhYQFrBLIOdu7Tv6Z7mI4fjnEZg 5fd4umS2Sdl/1mjGO2wbznfesdYdXXwtqJQ39Qo/Ds+onzt/Am+YnAueaxoixINd yElXId9YrzfGD3/lenBfS8IhiH0SJb2/cAXfpRVJsnWfnYRExfRmUH+kx7FlaLMz Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Bzi2xe ubX8MlqmqEvR0nJGejo91VSHTjaDrI/kVJWCY=; b=PDipjmT8Yq0EHfxWMYS7Wa C4+SnH/n8k6dbm8SSBDxAgCiJt48jNcqa5D5JNkTHRFdQpGf/YdG33cAKaHc1Jl+ SqrLMHeMvAfqEMh7+w1A41zcAQ1E7V5bhhONTSCdKfSarMprnExp9EC6Ec2iHTPg 5xSbGcpva7rGIaGFvesKrqXjQw3RWmyczA0nz7/0ThvaytN/p/STzBWGsHky4/oH O14fxSGfPCT4fSO9U9pdcn9pW8/QlclQlAb5kw6uIjsh6SXFbNYMCMnKW48mvUom 721fjxzKt+MS2cgcf4vq2R2XuNSHRoGfTWhuHv1F0tIQ27NOwZg8naXP0J1W7bVA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BC4DA7F91E; Mon, 23 Oct 2017 20:15:50 -0400 (EDT) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, "Eads, Gage" , "santosh.shukla@caviumnetworks.com" , "Richardson, Bruce" , "jerin.jacob@caviumnetworks.com" Date: Tue, 24 Oct 2017 02:15:49 +0200 Message-ID: <1835343.c7Vqvf7JSF@xps> In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E1400B993@FMSMSX108.amr.corp.intel.com> References: <20171005125017.GA12160@bricha3-MOBL3.ger.corp.intel.com> <20171012160421.8337-1-olivier.matz@6wind.com> <9184057F7FC11744A2107296B6B8EB1E1400B993@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/3] mk: fix LDLIBS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 00:15:52 -0000 23/10/2017 16:39, Eads, Gage: > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > > > Some libraries in LDLIBS are currently generated from the > > DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the > > subdirectory name match the library name, but it's not always the case, > > especially for PMDs. > > > > This series fixes some invalid dependency declarations first, and then removes > > the automatic generation of libraries from the directory names. Instead, the > > libraries are explicitly added in each Makefile. > > These three patches look good. I tested it on the contrived example from my original email, and this appears to fix the issue. > > Once the third patch's apply issues are resolved (http://dpdk.org/ml/archives/test-report/2017-October/032631.html): > Reviewed-by: Gage Eads Fixed some conflicts due to new PMDs and octeontx dependencies changes. Fixed some misses in patch 3 as explained in prior message. Applied with some fixes, thanks