DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_hash: Fix compile errors on IBM POWER
Date: Wed, 09 Dec 2015 21:22:15 +0100	[thread overview]
Message-ID: <1836160.8n9UzrWNog@xps13> (raw)
In-Reply-To: <20151209044000.GA5769@localhost.localdomain>

2015-12-09 10:10, Jerin Jacob:
> On Wed, Dec 09, 2015 at 12:11:47PM +0800, Chao Zhu wrote:
> > This patch fixes the compile errors caused by lacking of "size_t" definition in rte_hash.h. The
> > compile error exists on IBM POWER and ARM (see jerin.jacob@caviumnetworks.com's message).
> 
> remove relative references from git log,
> 
> - compile error exists on IBM POWER and ARM (see jerin.jacob@caviumnetworks.com's message).
> + compile error exists on IBM POWER and ARM64 GCC 5.2
> 
> > 
> > The errors are like:
> > In file included from /tmp/dpdk/app/test/test_hash_scaling.c:35:0:
> > /tmp/dpdk/build/include/rte_hash.h:70:70: error: unknown type name ‘size_t’
> >  typedef int (*rte_hash_cmp_eq_t)(const void *key1, const void *key2, size_t key_len);
> >                                                                       ^
> > /tmp/dpdk/build/include/rte_hash.h:120:48: error: unknown type name ‘rte_hash_cmp_eq_t’
> >  void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t func);
> 
> add fixes:
> 
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
> 
> with above changes,
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Applied, thanks

  reply	other threads:[~2015-12-09 20:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-09  4:11 Chao Zhu
2015-12-09  4:40 ` Jerin Jacob
2015-12-09 20:22   ` Thomas Monjalon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-12-08  8:28 Chao Zhu
2015-12-08  9:10 ` Jerin Jacob
2015-12-09  3:54   ` Chao Zhu
2015-12-08 10:05 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1836160.8n9UzrWNog@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).