From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 05C1C5957 for ; Tue, 25 Nov 2014 00:09:56 +0100 (CET) Received: by mail-wi0-f176.google.com with SMTP id ex7so7380025wid.9 for ; Mon, 24 Nov 2014 15:20:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=rmLpMB+6KBVMdLVBO5Sh719ND8waG7r8KveyG88T1Z8=; b=a+2MuBPjnUHf2vevSm/14NOj8M9PzHmLmv1PGqlKViSnthfQ/7yA+c0u4IbyUVqTjJ EdeR28XAtWvQkUg+4R8nQZXBGoIJ8KH7OEhLdF+0lTRkAyVknoDeV/jp5ozruu2lJ01Y RA2PjZVy4yvB6hhpZIuzCfeHYaOGcveVmy3Y+HpyL+9WeOnG9KO6xJqnPe8Nt2zqhSYV JhsAbahc0K3KmZbTcJ4ZacIuwzGlxYlI7OiXbx99CDBZ2qyo/5K5/QrNpY4qoPQoNyxB myzZX3+HqE8mkWrIsCIl/7EBImEG4d4gUELZjSufmKO31lE/vDyL6X7jHiIYZ8tZaQy2 6sig== X-Gm-Message-State: ALoCoQlExGInv2YBpKTKFst/iDaya2FvxNn96cUoUZ9moMRROF3aj4xlHpV0jYOBKjHKmyAwe4wS X-Received: by 10.194.157.35 with SMTP id wj3mr37652849wjb.91.1416871245738; Mon, 24 Nov 2014 15:20:45 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id p1sm23013435wjy.22.2014.11.24.15.20.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Nov 2014 15:20:44 -0800 (PST) From: Thomas Monjalon To: "Wu, Jingjing" Date: Tue, 25 Nov 2014 00:20:20 +0100 Message-ID: <1836839.nqfgSfhOYr@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <2601191342CEEE43887BDE71AB977258213B85BF@IRSMSX105.ger.corp.intel.com> References: <1414654006-7472-1-git-send-email-jingjing.wu@intel.com> <1416530816-2159-1-git-send-email-jingjing.wu@intel.com> <2601191342CEEE43887BDE71AB977258213B85BF@IRSMSX105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 00/22] Support flow director programming on Fortville X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2014 23:09:56 -0000 > > The patch set supports flow director on fortville. > > It includes: > > - set up/tear down fortville resources to support flow director, such as queue and vsi. > > - support operation to add or delete 8 flow types of the flow director filters, they are ipv4, tcpv4, udpv4, sctpv4, ipv6, tcpv6, udpv6, > > sctpv6. > > - support flushing flow director table (all filters). > > - support operation to get flow director information. > > - match status statistics, FD_ID report. > > - support operation to configure flexible payload and its mask > > - support flexible payload involved in comparison and flex bytes report. > > > > v2 changes: > > - create real fdir vsi and assign queue 0 pair to it. > > - check filter status report on the rx queue 0 > > > > v3 changes: > > - redefine filter APIs to support multi-kind filters > > - support sctpv4 and sctpv6 type flows > > - support flexible payload involved in comparison > > > > v4 changes: > > - strip the filter APIs definitions from this patch set > > - extend mbuf field to support flex bytes report. > > - fix typos. > > > > v5 changes: > > - redefine structure rte_eth_fdir_info > > - add doxygen comments about flexible payload and mbuf extend > > - fix typos > > > > v6 changes: > > - extend structure rte_eth_fdir_info > > - move the flex payload and mask setting from filter_ctrl api > > to i40e_fdir_configure when start device > > - change the structure for flex payload and mask setting, and > > add verification of those arguments before HW setting is taken. > > - change flexpayloads from words to bytes format > > - add two more flow_types > > - organize duplicate code lines to macro or function > > - add and correct doxygen comments > > - fix the merging error in v5 > > > > Jingjing Wu (22): > > i40e: set up and initialize flow director > > i40e: tear down flow director > > i40e: initialize flexible payload setting > > ethdev: define structures for adding/deleting flow director > > i40e: define functions for transition between flow_type and pctype > > i40e: implement operations to add/delete flow director > > testpmd: add test commands to add/delete flow director filter > > i40e: match counter for flow director > > mbuf: extend fdir field > > i40e: report flow director match info to mbuf > > testpmd: print extended fdir info in mbuf > > i40e: implement operation to flush flow director table > > testpmd: add test command to flush flow director table > > ethdev: define structures for getting flow director information > > i40e: implement operations to get fdir info > > ethdev: define structures for getting flow director statistics > > i40e: implement operations to get fdir statistics > > testpmd: display fdir info > > ethdev: add flexible payload setting in eth_conf > > i40e: take flow director flexible payload configuration > > testpmd: add test command to configure flexible mask > > testpmd: add test command to configure flexible payload > > Acked-by: Konstantin Ananyev I feel the flow director features could be better explained, and probably the API won't be enough generic for the next driver implementing flow director. But no comment from the community means it's OK to integrate. Now we move on this API and the old one must be removed. Converting ixgbe to this new API must be the top priority. It must be clear to everyone that no new Fortville feature will be accepted until a full clean-up of the old filtering API. Thank you Jingjing for the big work. Step done. Applied -- Thomas