From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F51CA0A0E; Mon, 10 May 2021 15:19:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA64040140; Mon, 10 May 2021 15:19:00 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by mails.dpdk.org (Postfix) with ESMTP id AB2984003E; Mon, 10 May 2021 15:18:59 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 4AF5411C1; Mon, 10 May 2021 09:18:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 10 May 2021 09:18:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 2so29Krz6NYGq4XqHX8UrxjK5sRkxA9yjI197v4OrjA=; b=dqnXQrS8sJIaYnqX IT31BGXA10aaPiGTK9AgB5Wu3ns8JWxhTOKSopZwByc3AHe6hogh3LTeajgyP1iC FV6mVzMtWW5cn3rNP7CIG7xP6jU738qCrsWQEEx5F7A2gWjFDDY5Gvyh4t5jxG+l 62qIBTnHXvEHCCS/n6w8zlQY4P2v1VfLQvsX7A9y8abpKVOK3BrzGZjf0hw1Gcxt eOwpc2sTRSW+yjqZ9QmGsoX6w+6gFUhzfGoSNFRpUTQovzfmuOTaIjvyOi7B+5W5 2p/4iVW8h8Mo8H3eqMiIxkvhAe+iHhDlSRYXzLDfYW2BUQKjVVFIZZ5r87wc+EPd LZEDKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=2so29Krz6NYGq4XqHX8UrxjK5sRkxA9yjI197v4Or jA=; b=d2FL4847RztNIv4w4U37t0QhWriibP/aDzrG9q9jtihvlB3zHcVSGcA/c dcfqx3u05Jmp7FBfAq1hsG34HnkGRiLsOqU/KnctlYxyFPw97A3ZlLCl2KnUv+IG 1cYRfku9bcKcfHYtj3o/oljyah4RB7e1rkgn+S1JHXCtLjJpszj9LIPHH4dje1Dk nAYj5740vqkVaNJmreEDeBerTQQJHTvsewmvgdNjKCauA0qFi+HRrGl2RLfjCbBr qoujx5GjDqYGY0LrcGeArzYU5TR5KJBc1JXpIk//QaKlsSSBqD/rGD2bw1M0jJdT SV/i64z3+HVeSccTAN/Q4UU4/oghA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegkedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 May 2021 09:18:56 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, Anatoly Burakov , Stephen Hemminger , Bruce Richardson Date: Mon, 10 May 2021 15:18:55 +0200 Message-ID: <1837679.WkC7EDQrBm@thomas> In-Reply-To: References: <20210506100637.23645-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix leak in shared lib mode detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/05/2021 12:40, Bruce Richardson: > On Thu, May 06, 2021 at 12:06:37PM +0200, David Marchand wrote: > > This is reported by our internal covscan: > > > > 1. dpdk-20.11/lib/librte_eal/common/eal_common_options.c:508: alloc_fn: > > Storage is returned from allocation function "dlopen". > > 6. dpdk-20.11/lib/librte_eal/common/eal_common_options.c:508: > > leaked_storage: Failing to save or free storage allocated by > > "dlopen("librte_eal.so.21.0", 5)" leaks it. > > > > # 506| * shared library is not already loaded i.e. it's > > # statically linked.) > > # 507| */ > > # 508|-> if (dlopen("librte_eal.so."ABI_VERSION, RTLD_LAZY | > > # RTLD_NOLOAD) != NULL && > > # 509| *default_solib_dir != '\0' && > > # 510| stat(default_solib_dir, &sb) == 0 && > > > > This leak is not an issue per se, but on the other hand, this is easy > > to fix and I prefer not having to waive this warning later. > > > > Fixes: 06c7871dde01 ("eal: restrict default plugin path to shared lib mode") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Acked-by: Bruce Richardson Applied, thanks