From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f42.google.com (mail-lf0-f42.google.com [209.85.215.42]) by dpdk.org (Postfix) with ESMTP id 8001158C8 for ; Mon, 3 Oct 2016 16:13:24 +0200 (CEST) Received: by mail-lf0-f42.google.com with SMTP id b75so24301184lfg.3 for ; Mon, 03 Oct 2016 07:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=uPc4Q/FiKuJLAKyqa/Qaumlv66Mu4V+yLAXkOzDCMos=; b=EM4Z/1xYOjfod1NEqIpQ3vHAXATe1o7A3V8eI/kxFhjFo7NpF1W2B+Upsz7kMlxsP1 0+dohjo48pIqqAzHbiwWRa27zJCtvJ6Ib4G/RnsWEQpzDyP1mlyH2K4saSbZ+RSXTI2q 12Rx5iaOHRB8+P9dFCOHM0Box6Al3XshNOKocgui5R3Hywd8S8p1re/AmIFC5QJ76MHp /Zezcab/Ttfo1NLHsq/de43bUxln0FoSyE+zI4vlPwtTrE64VgmEU0fv8h7lWMaGVi8x m57NC+Uw2qvAT5j+5hls+N7Qe8Rzk2wPqzzNtu8EoStLaHZm76BRn519tRumPmKoyau4 2uUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=uPc4Q/FiKuJLAKyqa/Qaumlv66Mu4V+yLAXkOzDCMos=; b=e0V8c26pQd6PjNlfmxJCNZnXxIGU0eKcJrvZuxm7Ewzl+zsuEhpf2Sz6898Wgpz9BT 3R87OxWPnjnGVwGJGuvcEt0Kr0+VSc+4bBh+NXrws4g30TqPL+murMvZtC4DJo8yGUUt CHC0c+fTBZWVquTLg0wjpMuSWGipSq4ZBPl4O4upJXfAViqJ3wED7UXgFH9fIYC6NvHM dpgXfqRF0ML73oNkXMaOAR22Ib8AgciKwF4yXvgCHkWj5kopjKAaVa//BetN/7rqnkop N8pmyshCDJPz4gHdzdRN9u73blRGnsgsyfAMxit81p+FokrW5jy8QbxpIXd4iJSrr5lD 07/g== X-Gm-Message-State: AA6/9Rn2CMxIGRe4+cmQWtqiGhQ/ek4ct49QyonoMsQTZIaRj0DymrfLeE5Un3mJPE7rrxql X-Received: by 10.195.2.73 with SMTP id bm9mr17951685wjd.21.1475504004123; Mon, 03 Oct 2016 07:13:24 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g9sm9391106wjk.25.2016.10.03.07.13.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 07:13:22 -0700 (PDT) From: Thomas Monjalon To: Flavio Leitner Cc: dev@dpdk.org, Aaron Conole Date: Mon, 03 Oct 2016 16:13:21 +0200 Message-ID: <1838224.hc711l76sy@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1474642051-9973-1-git-send-email-fbl@sysclose.org> <20160927183237.GA27384@plex> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: check cpu flags at init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2016 14:13:24 -0000 2016-09-29 16:42, Aaron Conole: > Flavio Leitner writes: > > > On Mon, Sep 26, 2016 at 11:43:37AM -0400, Aaron Conole wrote: > >> My only concern is whether this change would be considered ABI > >> breaking. I wouldn't think so, since it doesn't seem as though an > >> application would want to call this explicitly (and is spelled out as > >> such), but I can't be sure that it isn't already included in the > >> standard application API, and therefore needs to go through the change > >> process. > > > > I didn't want to change the original behavior more than needed. > > > > I think another patch would be necessary to change the whole EAL > > initialization because there's a bunch of rte_panic() there which > > aren't friendly with callers either. Yes please, we need to remove all those panic/exit calls. > Okay makes sense. > > Acked-by: Aaron Conole Applied, thanks