From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 17EBA1B5AC for ; Thu, 25 Apr 2019 15:29:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A42B821650; Thu, 25 Apr 2019 09:29:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Apr 2019 09:29:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=s4GCn8ANThEBEGLCHD9GX7e3serOthi4RKk4gU36dZg=; b=GK/Y7WbIHqCJ xjfmCNJdppNQJ9M6Hh094/eRybO7HSL/z5+SiRBi2ZaBk6TmTgsTo4nT/A6kEgVB l1q+GJgEpkz+JIn4KRPB5EMwGpPdVQV84AHpZ+/UdTHBHQiMLshIjN1k5WORHdwd PxqFRCXp0M4d8Z1ILYemxiJVva5e08Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=s4GCn8ANThEBEGLCHD9GX7e3serOthi4RKk4gU36d Zg=; b=mFijlHWTf9DdnXLJWtSBMOMiwvW49mrIv3amDobv58Ce7o0rnACbfb4Qd 3qP9MGKiBSwN15WTLSoVE4Fifo4RVsqjlATx8iWLujskYwxlpeO5BDByEYfPVPi9 ntB6QGh433yy/jESb9GwEXsJzGLBNrqcylxxSgJK9+89hPcjyi7YqT+2kBV4wIM2 GHSoQjUlMf7z6b3mqGhIwAKABYFPt+ahiXegFXCPESiCSC4NYG3yG+Ce4ZTdt0q8 hHgUtK2IWhN3RiVEHKbsjnYd4yEG5E1ClTOqJTjmQY3gXd6ghq0Nf6ByKKqM4uxM j1iIYVnpzc3ZwfSHIZInhUiGGqSqw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrheeggdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A9BA103DA; Thu, 25 Apr 2019 09:29:25 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Andrew Rybchenko , WenjieX A Li Date: Thu, 25 Apr 2019 15:29:22 +0200 Message-ID: <1838455.hGyFdCOQE1@xps> In-Reply-To: References: <20190424220309.84270-1-ferruh.yigit@intel.com> <2485235.lFPfLJtBTM@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Apr 2019 13:29:28 -0000 25/04/2019 13:47, Ferruh Yigit: > On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > > 25/04/2019 00:03, Ferruh Yigit: > >> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > >> > >> Not all PMDs support the fixed link speed set, and link speed can be set > >> even with auto negotiation enabled. Reverting the patch to not break > >> existing usage. > > > > Which PMDs do not support this flag? > > Why not fixing the PMDs? > > > > At least ixgbe and i40e is not supporting setting a fixed speed. > But I am not sure if this is something to fix, the command in testpmd is to set > the link speed, what is the problem with setting the link speed without > disabling the auto-negotiation? It means it will negotiate with only one speed proposed. The real issue is to not support the fixed flag. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 27A46A05D3 for ; Thu, 25 Apr 2019 15:29:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFAF51B5AD; Thu, 25 Apr 2019 15:29:29 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 17EBA1B5AC for ; Thu, 25 Apr 2019 15:29:28 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A42B821650; Thu, 25 Apr 2019 09:29:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Apr 2019 09:29:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=s4GCn8ANThEBEGLCHD9GX7e3serOthi4RKk4gU36dZg=; b=GK/Y7WbIHqCJ xjfmCNJdppNQJ9M6Hh094/eRybO7HSL/z5+SiRBi2ZaBk6TmTgsTo4nT/A6kEgVB l1q+GJgEpkz+JIn4KRPB5EMwGpPdVQV84AHpZ+/UdTHBHQiMLshIjN1k5WORHdwd PxqFRCXp0M4d8Z1ILYemxiJVva5e08Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=s4GCn8ANThEBEGLCHD9GX7e3serOthi4RKk4gU36d Zg=; b=mFijlHWTf9DdnXLJWtSBMOMiwvW49mrIv3amDobv58Ce7o0rnACbfb4Qd 3qP9MGKiBSwN15WTLSoVE4Fifo4RVsqjlATx8iWLujskYwxlpeO5BDByEYfPVPi9 ntB6QGh433yy/jESb9GwEXsJzGLBNrqcylxxSgJK9+89hPcjyi7YqT+2kBV4wIM2 GHSoQjUlMf7z6b3mqGhIwAKABYFPt+ahiXegFXCPESiCSC4NYG3yG+Ce4ZTdt0q8 hHgUtK2IWhN3RiVEHKbsjnYd4yEG5E1ClTOqJTjmQY3gXd6ghq0Nf6ByKKqM4uxM j1iIYVnpzc3ZwfSHIZInhUiGGqSqw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrheeggdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epkeefrdduudehrdduheehrddufeeknecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (acaen-257-1-30-138.w83-115.abo.wanadoo.fr [83.115.155.138]) by mail.messagingengine.com (Postfix) with ESMTPA id 7A9BA103DA; Thu, 25 Apr 2019 09:29:25 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Andrew Rybchenko , WenjieX A Li Date: Thu, 25 Apr 2019 15:29:22 +0200 Message-ID: <1838455.hGyFdCOQE1@xps> In-Reply-To: References: <20190424220309.84270-1-ferruh.yigit@intel.com> <2485235.lFPfLJtBTM@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190425132922.H0XN53TdKnpwToa27SWOfr9aEzfOrZw7iTmp5pivZFk@z> 25/04/2019 13:47, Ferruh Yigit: > On 4/25/2019 9:19 AM, Thomas Monjalon wrote: > > 25/04/2019 00:03, Ferruh Yigit: > >> This reverts commit bdca79053b6aea504d02691d9319fa976062457f. > >> > >> Not all PMDs support the fixed link speed set, and link speed can be set > >> even with auto negotiation enabled. Reverting the patch to not break > >> existing usage. > > > > Which PMDs do not support this flag? > > Why not fixing the PMDs? > > > > At least ixgbe and i40e is not supporting setting a fixed speed. > But I am not sure if this is something to fix, the command in testpmd is to set > the link speed, what is the problem with setting the link speed without > disabling the auto-negotiation? It means it will negotiate with only one speed proposed. The real issue is to not support the fixed flag.