From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id BC6A25A54 for ; Fri, 5 Jun 2015 15:41:35 +0200 (CEST) Received: by wiwd19 with SMTP id d19so21681545wiw.0 for ; Fri, 05 Jun 2015 06:41:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=/cAKKGRTk+vsxlPu0Q+0DAj1GrL5MpN6DJ/rMsduDp8=; b=VCkAUhl7f6Qb5T/W06FT/BJKPMU2XjpA+1YUlZj/hlRbYCktFRJWpWutITP/kbsi0P 7XlJC7wzBM1fgfIg6XMy3aSKBWppbJnFluMTlfg+7wEwbKxie1lKknaY0lrKJ1p9aH4j NAGyqAec9HTnxtwFMXMrHumfWqo7m2tRlPX7/5WwPuLuEWixELW0AY3sPyrQwlKo50AP p3j/d72qYkfTKnfObSsyjiQ8HFPwiOmj0RDyZ5LrsAvmS3nEbquiTp569ZEANup6xuQ/ LaLlCH3ffb/CLvE0qeC606tyMcP1Matnv1GibfYSDGIl/z11A81bH77p6ruV6gm0Fznh jn9g== X-Gm-Message-State: ALoCoQlUu7M/VYhUkFhEeCwM5CE1vJuxcVBqXbFFCtYHSdaHgjnVN6iJrhfUqILAf++NSiAtR/U3 X-Received: by 10.181.6.37 with SMTP id cr5mr62134717wid.18.1433511695641; Fri, 05 Jun 2015 06:41:35 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ej5sm10665253wjd.22.2015.06.05.06.41.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 06:41:35 -0700 (PDT) From: Thomas Monjalon To: "Wang, Liang-min" Date: Fri, 05 Jun 2015 15:40:42 +0200 Message-ID: <1840741.YhHFF9Rtvs@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <18146131.KjMWrd7xqb@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Jun 2015 13:41:36 -0000 2015-06-05 11:25, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Stephen and me say the same thing about using the ethdev API. > > We don't understand why using a fake ethtool lib would be easier. > > Though you are saying it "facilitated [your] adoption to dpdk". > > Please could you explain why using an ethtool-like API is easier than using > > the existing ethdev API? > > In any case, you have to develop a specific backend for DPDK (rte_ethtool > > would be also DPDK-specific). > > As described earlier in this patch comment reply, there are other ethtool ops that have been implemented. > Those ops includes set/get eeprom, set/get pauseparam, set/get ringparam which are not available in the exiting ethdev library. 1/ We cannot really consider code which is not public 2/ You may extend ethdev if some functions are missing > For this release, we focus on releasing some basic functions (btw, mac_addr_set is not available but is covered by this patch). Yes, you are extending ethdev by adding rte_eth_dev_default_mac_addr_set. > The key reason that this set of library is not released as part of ethdev is the ethtool API dependency on kernel include file. It is a good reason to separate the library. But it doesn't justify its need. > To faithfully carry the ethtool ops and net dev ops API parameters, the ethtool APIs are designed to follow the original definition except avoiding carry kernel states. > With that, to support ethtool APIs faithfully, we need to include . > As suggested by many DPDK veterans including Thomas (indicated over your reply), you would prefer these APIs in a separate library. I think I'm starting to understand that you really need ethtool conversion (implemented in rte_ethtool_get_drvinfo) but not the other functions which are simple wrappers. Right?