From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4737A00C3; Mon, 17 Jan 2022 15:10:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66EE3411F3; Mon, 17 Jan 2022 15:10:19 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id D38B240141 for ; Mon, 17 Jan 2022 15:10:18 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8381D5C0ECF; Mon, 17 Jan 2022 09:10:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 17 Jan 2022 09:10:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= rQ/cu+U3NlY9yB6LjAH++Klw8/nld2EroSVxou2yUWc=; b=pWFSv9EnyjZ4BboW fE7MqL687iru/uj1dLcLzqEUngAu2D0Gx+zrQ0OvyrVdw+XeAHsn2qp3OId37LFE fVzMX7jVsbElsrsVEEspj/xHp4Kb71Kqm4P/Ju04Qrov/J8Yf6F2aUM62v3vOU0t 4X1qgrRr6vk0KekV9tX5fuQfwc5McHIJokzn+Oy1FeYF1fFtTPF6jgstW5O/R/ow 1quA/a0+c5/kkobWE0ina1P1QurvFP/9d91hoEy6GAsrkN2v03cU0bPIt5JDJWmG 0+5ajw23kZevbweLBzum3u7IEjcdpZ0G/SE+Hu1UakT/U6ztzgZHJfqW2P6Duz57 b14c9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rQ/cu+U3NlY9yB6LjAH++Klw8/nld2EroSVxou2yU Wc=; b=cuaZytBEENCjlNwT0TE6plolRC32gNM8DyCzeOxUp5cHXr4GjUWeHppBu gC+nuFFrrjmGQ1BaE3Lb0l7jp3tR1bVaDzG8votF66vXNj08C+Su20H4UNvg2Awq IGqrMFWGuIwIkNvM0QSKqCkMm7t2rEtfC8zBrYlpi/m4hH2olPTSw0L2OZFODWzL Fp0m3sot6HI4kJWrure4FIRNgGFnJIamnFn2WgirVpnpv+H7GcQB5kUNmEamu/D6 ESfqmf34jrh/BMpqFdlNJnRqT6IFLYIVzDaOM1hfYz1BaGUHAiCoFT25x9397V4d fO785PsoYQfP3J032g+Q3cVu+/iDA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddugdeivdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jan 2022 09:10:17 -0500 (EST) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Anatoly Burakov Subject: Re: [PATCH v1 4/6] eal: refactor --huge-unlink storage Date: Mon, 17 Jan 2022 15:10:16 +0100 Message-ID: <1841239.g5d078U9FE@thomas> In-Reply-To: <20220117080801.481568-5-dkozlyuk@nvidia.com> References: <20211230143744.3550098-1-dkozlyuk@nvidia.com> <20220117080801.481568-1-dkozlyuk@nvidia.com> <20220117080801.481568-5-dkozlyuk@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/01/2022 09:07, Dmitry Kozlyuk: > In preparation to extend --huge-unlink option semantics > refactor how it is stored in the internal configuration. > It makes future changes more isolated. > > Signed-off-by: Dmitry Kozlyuk > --- > +/** Hugepage backing files discipline. */ > +struct hugepage_file_discipline { > + /** Unlink files before mapping them to leave no trace in hugetlbfs. */ > + bool unlink_before_mapping; > +}; [...] > - unsigned hugepage_unlink; /**< true to unlink backing files */ > + struct hugepage_file_discipline hugepage_file; That's clearer, thanks. Acked-by: Thomas Monjalon