From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCFA5A00C3; Fri, 4 Feb 2022 08:47:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 425EC40143; Fri, 4 Feb 2022 08:47:57 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 1140040140 for ; Fri, 4 Feb 2022 08:47:56 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B045C32005C1; Fri, 4 Feb 2022 02:47:54 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 04 Feb 2022 02:47:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=3//JSqle7ud9N8 xN95jGh9uLw/ftqYit33Py5ithU0c=; b=fSQxhtWJ0k5qw/GIaSbL5yBkUm1YMv vnE5htZqxu3QzClAko9JrMaAjxLY+73XOgUA6LH6st+PukhGqw5octPqgVS557lN cXIqwmXE8GvxduXhSFK1zhTDKNSh1sQFWfRXTBWgmbeMeLNJQ9mQfdDFSW3YwsMw F5ZNpzAl6qwDx7RRV8RAQuWR6xABghrSlAxXCTr7ohoyCT/9HhEclY/fXpP/lB4L rHoQZFdVnNzn0vgd91I1J2WsD4wft2ZCWzrG9LFhgeZ3yqWvjSYz0QZkKu2caTXx WXetANVo6/5F00xmNY6XxH+VNA+u9QnTZlAewku7cPq50iXWQ5sI9wjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=3//JSqle7ud9N8xN95jGh9uLw/ftqYit33Py5ithU 0c=; b=giDkxL+sM6ODHhdSgCYVth6CF1Bce/EXJC4hhjz4vmi6Hw7phpeQE9WMF iJaxR8i3WQqF57L3x5CMSQ6wYKkyaFyTM0I7AjYHOcuJeFFdZ1WUL1u/VEBAqvL2 P4wWe6t5nfGDgmgLy3NXy6Mq3fKiyQLy0/G/p/ZpPyznWXbyKZH6SRiYU/Scn1Dh cP6mLiyG8todyQjFq4DcL8q1q8DiQi5ft93xi+Iyahn4W2RNRIcVNX3/yXeLuAeR u3fyQOWS7ghJsQUvC+r3efgnreR9ZOcV3298ByfbZwNzEvF4WTgs68je5rySR5SO bnbc7X2W8NwwNjQIgagOlBOZrx/rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeekgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 4 Feb 2022 02:47:53 -0500 (EST) From: Thomas Monjalon To: "Singh, Aman Deep" Cc: dev@dpdk.org, ferruh.yigit@intel.com Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace Date: Fri, 04 Feb 2022 08:47:51 +0100 Message-ID: <1842607.g5d078U9FE@thomas> In-Reply-To: <2f156089-44ad-776a-c483-9ff62c8c716a@intel.com> References: <20220123172046.1296964-1-aman.deep.singh@intel.com> <14548884.JCcGWNJJiE@thomas> <2f156089-44ad-776a-c483-9ff62c8c716a@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 04/02/2022 07:13, Singh, Aman Deep: > Hi Thomas > > On 2/3/2022 2:31 AM, Thomas Monjalon wrote: > > 23/01/2022 18:20, Aman Singh: > >> Added two specific exceptions for ETH_SPEED_10G > >> and ETH_SPEED_25G to avoid there name change. > >> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA > > Please could you explain why? > These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga > driver and script should no change these. > There are multiple ETH_SPEED_NUM_xxx macro that need to be changed > to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions. Why doing this exception? What is special with ifpga? > The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before. > The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA The explanations should be part of the commit log please.