From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FEA9A00BE; Thu, 10 Feb 2022 16:30:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC2B1426EE; Thu, 10 Feb 2022 16:30:33 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 0365F426ED for ; Thu, 10 Feb 2022 16:30:32 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 71B245C01E8; Thu, 10 Feb 2022 10:30:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 10 Feb 2022 10:30:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=5SKqL5TNINPWiN iYU5pNJwJqysB5x1L2/RV4YDMS1Ik=; b=q6nqNW1jszSBCeQaSapszzKcSg0NJu IHuIkd1w5WoaVOsQVuxLYDaQPReYLe6l0vlJTAt1PGb2H66yqX8y5zl9TFGTkocO l5VilZE+BkHQU4p9QFzX0TSLUDiyUCFYdwitKWCSmUH5dNgL1NrmqfGtmcuttXoj TcVyC/gC+ckr2xTwPJmyGV066Yespx8PLt/8G0x9db+aZu46vEexONQ0mYv4So/s zwg1R4a8/5fD6qO84hVsJle+SflD2rhrYJ4cuGvTm8b04+TX/8DrDm2mGwsa03jb 9F+zVbNoxZcUZFG/urqv2FxzENYSa+iFr15iS/WE3eZxFRz/wY1jlzog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=5SKqL5TNINPWiNiYU5pNJwJqysB5x1L2/RV4YDMS1 Ik=; b=Q9iO4l+dItpSQo9CQ2cv50ANJYT2UUDGNLe/WMMgXirikZpkm1YboSGPv FE2A/SKq0nHTvgPAmEKSYtIeh1tEe3/Ts2UQmazacz30/+PnVwim5syOsmXdhfiI LyCLeQEOpkaEhkoTGrKOTts1/h5/NAGcntEIVckOQfj+7g5+2R+5dQI0x3GsPrdF qAr3zpyCX+Fmfhi5GBvCuucVwkinzI81qAnkty1gesMLOnhLV5NX+bC5dxUnokax IQyySw7GEVI14NeWZ0gFHi9L/DKB1q51uU4HkuZaQXFOioNVcy1fkJiVKmLjB/mx FeV2DTQnF7gb+GhPfU3/DCijT6DgA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddriedugdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Feb 2022 10:30:31 -0500 (EST) From: Thomas Monjalon To: "Singh, Aman Deep" Cc: dev@dpdk.org, ferruh.yigit@intel.com Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace Date: Thu, 10 Feb 2022 16:30:30 +0100 Message-ID: <1843605.IobQ9Gjlxr@thomas> In-Reply-To: References: <20220123172046.1296964-1-aman.deep.singh@intel.com> <1842607.g5d078U9FE@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 10/02/2022 14:26, Singh, Aman Deep: > On 2/4/2022 1:17 PM, Thomas Monjalon wrote: > > 04/02/2022 07:13, Singh, Aman Deep: > >> Hi Thomas > >> > >> On 2/3/2022 2:31 AM, Thomas Monjalon wrote: > >>> 23/01/2022 18:20, Aman Singh: > >>>> Added two specific exceptions for ETH_SPEED_10G > >>>> and ETH_SPEED_25G to avoid there name change. > >>>> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA > >>> Please could you explain why? > >> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga > >> driver and script should no change these. > >> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed > >> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions. > > Why doing this exception? What is special with ifpga? > > These two macro's are defined in 'ifpga/base/opae_eth_group.h' > we don't intend to change these. Target is ethdev namespace only. So we will miss future use of a deprecated macro because ifpga is redefining it? I think it is a wrong approach. We should not make any exception in the check. Instead we can just ignore the warning for ifpga. > >> The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before. > >> The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA > > The explanations should be part of the commit log please. > > Sure, if this explanation is fine? Will update in next version. Yes thanks.