From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f173.google.com (mail-we0-f173.google.com [74.125.82.173]) by dpdk.org (Postfix) with ESMTP id 7F8A2B106 for ; Fri, 27 Jun 2014 02:36:56 +0200 (CEST) Received: by mail-we0-f173.google.com with SMTP id t60so4449542wes.32 for ; Thu, 26 Jun 2014 17:37:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=pa/H5O5sAsRENBpg1uvFNhRKuAsQBfqw3B2mtndy9E4=; b=Cyr+3kjY41OyeccnMYef5QjVibW1wWtGyIxnqLnoCBbehwEfx5qMZHOPJIrNly8EVY zTBO8lpouwHrRetLTzStJ3sFjp4W4goDcx5kJDIdCfZ3g8r8pwE2xTFEihzsOFqSaCSa p951wJ/CkNENNqiGMKyWzd4ZI6Thea4Z1p1P4ma7iEn3EAZ9ef2e0Ce9XFCc1drh4WEc oe9f6g4jTnIS7KdZeHYwGiZsbG5tVbi0UPjF/JXT0MXDLsMN1eYBVfd0tAWCQ6v9+BG7 PMIkJFfWmhDtf1A1+KA83OmMF9mw96Z9pF39h1uDvqq7TvCY+j7y3C6aVvh7JEanF/Jo uvPw== X-Gm-Message-State: ALoCoQkhUEQt+XkkTM9E58e163wJu8F9f+fHfNwV5phydmUXiO02uYnKkpMYcjrw6OIAp/yuO7Jk X-Received: by 10.194.77.103 with SMTP id r7mr21701144wjw.67.1403829435639; Thu, 26 Jun 2014 17:37:15 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gi7sm71573164wib.1.2014.06.26.17.37.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jun 2014 17:37:14 -0700 (PDT) From: Thomas Monjalon To: Aaron Campbell , "Richardson, Bruce" Date: Fri, 27 Jun 2014 02:37:09 +0200 Message-ID: <1844098.FugtUsePJs@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <5590E373-EC37-4544-A983-52156CFA81E2@arbor.net> References: <20140624090253.140206a7@nehalam.linuxnetplumber.net> <59AF69C657FD0841A61C55336867B5B02CEF87D2@IRSMSX103.ger.corp.intel.com> <5590E373-EC37-4544-A983-52156CFA81E2@arbor.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jun 2014 00:36:56 -0000 2014-06-26 13:20, Aaron Campbell: > On Jun 26, 2014, at 12:09 PM, Richardson, Bruce =20 wrote: > >> I agree we should try to use the "deprecated" attribute when possi= ble. > >> So application porting effort will be smoother. > >>=20 > >> But in this case, there is something different: as Stephen wrote, > >> rte_snprintf is useless. It's useless inside the DPDK so it's even= more > >> useless for user applications. > >> As it's really useless, it has no sense to keep it as deprecated. > >> Please, let's simply remove it. > >=20 > > The reason to keep it as deprecated is so that those customers who = don't > > want to do a huge amount of search-replace immediately can get thin= gs > > working again temporarily using -Wno-deprecated. It provides a simp= le > > temporary fallback cushion, and then we can completely remove the > > function later. So, I'd like to see us remove all our usage of the > > function internally in 1.7, along with marking as deprecated, and t= hen > > completely remove in 1.8, (i.e. in a week's time or so) :-) >=20 > As a DPDK user, I=E2=80=99d vote to kill it now. I doubt it is widel= y used in any > external applications. Such usage would be mostly from copy/pasting = the > sample code, is my guess. I think everybody understood the idea: we'll try to use deprecation mod= el when=20 possible. In this case, it's probably useless but we close the discussion by depr= ecating=20 it. We'll remove it soon, don't worry :) --=20 Thomas