From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id DBC20A04F9;
Thu, 9 Jan 2020 23:18:44 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 117A71E55F;
Thu, 9 Jan 2020 23:18:44 +0100 (CET)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 8F4CE1E559
for <dev@dpdk.org>; Thu, 9 Jan 2020 23:18:42 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
09 Jan 2020 14:18:41 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.69,414,1571727600";
d="scan'208,217";a="421919781"
Received: from unknown (HELO [10.241.225.109]) ([10.241.225.109])
by fmsmga005.fm.intel.com with ESMTP; 09 Jan 2020 14:18:40 -0800
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, thomas@monjalon.net, Harini.Ramakrishnan@microsoft.com,
keith.wiles@intel.com, bruce.richardson@intel.com,
david.marchand@redhat.com, jerinjacobk@gmail.com, ranjit.menon@intel.com,
antara.ganesh.kolar@intel.com
References: <20191022200227.1920-1-pallavi.kadam@intel.com>
<20200109031312.6344-1-pallavi.kadam@intel.com>
<20200109031312.6344-7-pallavi.kadam@intel.com>
<20200108223557.42244512@hermes.lan>
From: Pallavi Kadam <pallavi.kadam@intel.com>
Message-ID: <1846093f-d18c-1e4a-b220-b478b7e8122a@intel.com>
Date: Thu, 9 Jan 2020 14:18:38 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.9.1
MIME-Version: 1.0
In-Reply-To: <20200108223557.42244512@hermes.lan>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v4 6/9] eal: add function to detect process
type
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 1/8/2020 10:35 PM, Stephen Hemminger wrote:
> On Wed, 8 Jan 2020 19:13:09 -0800
> Pallavi Kadam <pallavi.kadam@intel.com> wrote:
>
> Minor comments
>
>> /* Address of global and public configuration */
>> -static struct rte_config rte_config;
>> +static struct rte_config rte_config = {
>> + .mem_config = &early_mem_config,
>> +};
> Only single tab is needed for indent here
>
> +enum rte_proc_type_t
> + eal_proc_type_detect(void)
>
> put function in column 1.
>
> enum rte_proc_type_t
> eal_proc_type_detect(void)
>
> In a related vain, the existing code fore eal_create_cpu_map does
> not follow DPDK coding style at all. It has weird indentation of
> for loops and uses C99 style declarations of loop variables.
> I guess nobody on Linux side ever looked at the Windows code for that.
Thanks, Stephen.
Will fix this single tab indent in v5.
Also, will send a new patch for eal_create_cpu_map function.
Can you please suggest what exact changes are required here.