From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2BF2E271 for ; Mon, 3 Jul 2017 22:51:50 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B59762089D; Mon, 3 Jul 2017 16:51:49 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 03 Jul 2017 16:51:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=OrkzmuISKUOHhmr azY+/mIRTcOcgWnNObIMFx9WG/zA=; b=UUCIQog04GG/dWTd9YjTXQoJp9bEwDy cQGl1kOh+EVF0aR/uEDHvnFET5xlZaC9G37uojR/SSU5jBN27Q05oFH+X7rMfHvB D3x4bNsuSf2E1E29RypYL48SspQQ0kBwIWCxRxHq2XaxMKhFsxIcyK8kwBdc+rUN A0a7ynDKOLHM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=OrkzmuISKUOHhmrazY+/mIRTcOcgWnNObIMFx9WG/zA=; b=g2+qBVWM yXU7+b50nj0euNEZIt1GKyLq2AO1Asp8bfw2Ee0HKEXDNAuCIwgQt1DHEds9g83m 6NKUD5ScUYGiyMpNNZaGdsFIhj4PcT7gTewZ8gsMZdc9sAKc+l9YeevE2eXW+3qb V67PMQm3PiTsFltgZfoZ7FzqT478HE7yZE8/+j+q6EpLTBwdTr+3NbcZa2oEJpwo uJBm0fWpmU1cO4K3M5KqURi9bSAlk/i/AfeAJrPZ8M4kBPTTKjUNVo+D2eaOvZkB RMKg5EvnWeocpPL3UGNTnatrMppron2nU08nB2nNQmXs7X8H+XVtFJfG9vJL7F9/ 4Ur9+JlNMXbdbQ== X-ME-Sender: X-Sasl-enc: 3OMGL6cF9WBHEkoqpFz1ElbbD+tYL8rR57trX5hk6cJ0 1499115109 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 68C1A7E84B; Mon, 3 Jul 2017 16:51:49 -0400 (EDT) From: Thomas Monjalon To: Ashwin Sekhar T K Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, viktorin@rehivetech.com, jianbo.liu@linaro.org, jasvinder.singh@intel.com Date: Mon, 03 Jul 2017 22:51:48 +0200 Message-ID: <1846974.hN7or4i1Z4@xps> In-Reply-To: <20170512101535.7221-3-ashwin.sekhar@caviumnetworks.com> References: <20170427140618.35897-1-ashwin.sekhar@caviumnetworks.com> <20170512101535.7221-1-ashwin.sekhar@caviumnetworks.com> <20170512101535.7221-3-ashwin.sekhar@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 2/4] eal: move gcc version definition to common header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 20:51:50 -0000 12/05/2017 12:15, Ashwin Sekhar T K: > Moved the definition of GCC_VERSION from lib/librte_table/rte_lru.h > to lib/librte_eal/common/include/rte_common.h. > > Tested compilation on: > * arm64 with gcc > * x86 with gcc and clang > > Signed-off-by: Ashwin Sekhar T K > Reviewed-by: Jan Viktorin > --- > --- a/lib/librte_eal/common/include/rte_common.h > +++ b/lib/librte_eal/common/include/rte_common.h > +/** Define GCC_VERSION **/ > +#ifdef RTE_TOOLCHAIN_GCC > +#define GCC_VERSION (__GNUC__ * 10000 + __GNUC_MINOR__ * 100 + \ > + __GNUC_PATCHLEVEL__) > +#endif [...] > --- a/lib/librte_table/rte_lru.h > +++ b/lib/librte_table/rte_lru.h > -#ifdef __INTEL_COMPILER > -#define GCC_VERSION (0) > -#else > -#define GCC_VERSION (__GNUC__ * 10000+__GNUC_MINOR__*100 + __GNUC_PATCHLEVEL__) > -#endif The ICC check is lost when moving in rte_common.h.