From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3FDF22BD3 for <dev@dpdk.org>; Thu, 28 Mar 2019 21:44:35 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B07D822738; Thu, 28 Mar 2019 16:44:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 16:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LLo8NiCTjtVIZGqDr2TB7vZQVL0nG76cp5TZgmiCPis=; b=cUQFgE2GoKyf EASw6YgAt7pV3nZl1hDwgZfkjzlfsB6kxLl94tJbFbYebLWOhQ0ShvIPhBgQclBB fMBVOSC2xDMwSadc6zHJe9NLilUoaXxqmm4gAJecHQAXCog5UVgMEDSrTunqWXpw iBA437KqLqeD4vp7SmvrN4MFbdapkhQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LLo8NiCTjtVIZGqDr2TB7vZQVL0nG76cp5TZgmiCP is=; b=2/KvFWEvN7I9oN9m8FtWeuyji5RFxPG6m5VeNYxAKWBKVuZL5bTMZz63e T9OW5ofNFuVLj7JtQymJEwxQDEJAKl+r2P/ON45dL4MJm9BtzJHs0spVdzciRn42 pIMcGQJUXEMxJXSU0N3FJnaxXaYNDXzL/i0snPtFoIVyGu7Y/vLyE/W0mvudILYm x67M+8lf7jbYuF7ZvJ5oyUyLi/qC4gnce0GAElXuRtKoLjqguY/BIpkBhkgvMz7n B9Hx3rE/UPcx5MViJCnOjoGS32woF6+aGGHghDZvNOG+wqLhlSA8oMJntzQUAckN c6tB2ZdDsQkeBNJsjvztEQaoe7Ztg== X-ME-Sender: <xms:MTKdXLDmIt-AH-tIa6rdwvj0QC7R5KZ7XqHzsPs59ciWYeq7JkeJgw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:MTKdXHpdjUJSZWrM2lmP0N2lYE68kElrvpI0ldN_FDhKUs7uPnk51A> <xmx:MTKdXMIQYPulY47bfCWEIUqehEBmAa1y_GBOgtInCDXwAvjzP-n2HA> <xmx:MTKdXBIM80vJh_bivVwA9UiBQOhAeFirnracvqelve-M1xY5rvV2-A> <xmx:MjKdXEkts3DzyEwh7ZwrUGolEB31u4MoE9n9lF-9BKP0HwZsgbJ02A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FE17100E5; Thu, 28 Mar 2019 16:44:33 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Anatoly Burakov <anatoly.burakov@intel.com> Cc: dev@dpdk.org Date: Thu, 28 Mar 2019 21:44:32 +0100 Message-ID: <1848003.AzJ49HI9Wz@xps> In-Reply-To: <d43eba58247bbd4a5c3eb1eb36cd728338daf364.1551201154.git.anatoly.burakov@intel.com> References: <d43eba58247bbd4a5c3eb1eb36cd728338daf364.1551201154.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 28 Mar 2019 20:44:35 -0000 26/02/2019 18:13, Anatoly Burakov: > Currently, there are numerous reliability issues with fbarray, > such as: > - There is no way to prevent attaching to overlapping memory > areas > - There is no way to prevent double-detach > - Failed destroy leaves fbarray in an invalid state (fbarray > itself is valid, but its backing memory area is already > detached) > > In addition, on FreeBSD, doing mmap() on a file descriptor > does not keep the lock, so we also need to store the fd > in order to keep the lock. > > This patch improves upon fbarray to address both of these > issues by adding an internal tailq to track allocated areas > and their respective file descriptors. > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4AC30A0679 for <public@inbox.dpdk.org>; Thu, 28 Mar 2019 21:44:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54F082C19; Thu, 28 Mar 2019 21:44:36 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 3FDF22BD3 for <dev@dpdk.org>; Thu, 28 Mar 2019 21:44:35 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B07D822738; Thu, 28 Mar 2019 16:44:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 16:44:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LLo8NiCTjtVIZGqDr2TB7vZQVL0nG76cp5TZgmiCPis=; b=cUQFgE2GoKyf EASw6YgAt7pV3nZl1hDwgZfkjzlfsB6kxLl94tJbFbYebLWOhQ0ShvIPhBgQclBB fMBVOSC2xDMwSadc6zHJe9NLilUoaXxqmm4gAJecHQAXCog5UVgMEDSrTunqWXpw iBA437KqLqeD4vp7SmvrN4MFbdapkhQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LLo8NiCTjtVIZGqDr2TB7vZQVL0nG76cp5TZgmiCP is=; b=2/KvFWEvN7I9oN9m8FtWeuyji5RFxPG6m5VeNYxAKWBKVuZL5bTMZz63e T9OW5ofNFuVLj7JtQymJEwxQDEJAKl+r2P/ON45dL4MJm9BtzJHs0spVdzciRn42 pIMcGQJUXEMxJXSU0N3FJnaxXaYNDXzL/i0snPtFoIVyGu7Y/vLyE/W0mvudILYm x67M+8lf7jbYuF7ZvJ5oyUyLi/qC4gnce0GAElXuRtKoLjqguY/BIpkBhkgvMz7n B9Hx3rE/UPcx5MViJCnOjoGS32woF6+aGGHghDZvNOG+wqLhlSA8oMJntzQUAckN c6tB2ZdDsQkeBNJsjvztEQaoe7Ztg== X-ME-Sender: <xms:MTKdXLDmIt-AH-tIa6rdwvj0QC7R5KZ7XqHzsPs59ciWYeq7JkeJgw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggddugedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:MTKdXHpdjUJSZWrM2lmP0N2lYE68kElrvpI0ldN_FDhKUs7uPnk51A> <xmx:MTKdXMIQYPulY47bfCWEIUqehEBmAa1y_GBOgtInCDXwAvjzP-n2HA> <xmx:MTKdXBIM80vJh_bivVwA9UiBQOhAeFirnracvqelve-M1xY5rvV2-A> <xmx:MjKdXEkts3DzyEwh7ZwrUGolEB31u4MoE9n9lF-9BKP0HwZsgbJ02A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 5FE17100E5; Thu, 28 Mar 2019 16:44:33 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Anatoly Burakov <anatoly.burakov@intel.com> Cc: dev@dpdk.org Date: Thu, 28 Mar 2019 21:44:32 +0100 Message-ID: <1848003.AzJ49HI9Wz@xps> In-Reply-To: <d43eba58247bbd4a5c3eb1eb36cd728338daf364.1551201154.git.anatoly.burakov@intel.com> References: <d43eba58247bbd4a5c3eb1eb36cd728338daf364.1551201154.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] fbarray: add internal tailq for mapped areas X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190328204432.QNan744NzJ_NFXWoJhS0XPhbDa0CxqoZH76cEt31c0E@z> 26/02/2019 18:13, Anatoly Burakov: > Currently, there are numerous reliability issues with fbarray, > such as: > - There is no way to prevent attaching to overlapping memory > areas > - There is no way to prevent double-detach > - Failed destroy leaves fbarray in an invalid state (fbarray > itself is valid, but its backing memory area is already > detached) > > In addition, on FreeBSD, doing mmap() on a file descriptor > does not keep the lock, so we also need to store the fd > in order to keep the lock. > > This patch improves upon fbarray to address both of these > issues by adding an internal tailq to track allocated areas > and their respective file descriptors. > > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> Applied, thanks