From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 342F2A04DD; Tue, 21 Jan 2020 14:39:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C459E1252; Tue, 21 Jan 2020 14:39:51 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 65E2EF94 for ; Tue, 21 Jan 2020 14:39:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F239622136; Tue, 21 Jan 2020 08:39:48 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 21 Jan 2020 08:39:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kBv7ltWfnGfDEnT4A3REKarw1KEP7Sp8hSqxnjr9p5Q=; b=MtT8ncrcQUnW kv1Gs5UaXswlvpfggQ5oQZ1uXuhMZn3ctXvFvN1Dwuhj8fjneD8wP/ITRL+zKN1R o2FWTcVupcIF28115STYQL7efZz92Vi/+/GGxVdOO1zDQBUbhExot70Ejr2hRvvL uZSsCW3sCMKW/kub7zOjIKBvQ/WSRV8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=kBv7ltWfnGfDEnT4A3REKarw1KEP7Sp8hSqxnjr9p 5Q=; b=j0bQwDqQralk80f7/BpwQcOgeAGPiaNZih4pUqjHFw1mVgTA4QpDzSabx DKX6eckBhCMT9j0Co6FUMiOp72ZHpUob4xXi2jyCSK952hD+L94CDfLiK/rPHHCd 39Cv7tpSs2wpEqEvdIUI47aIk3Ct+xji+5SotTir3B52df5gH8MQMunSbuE5vO+x 94Sv9mvaZZu5ThQ33B9P6vODHpeoXu+DFtU9vhW6Hdq9cJ8u4vNelTgbIEzOJ1UA +vH3rLajSSCT07y8uMD6ytpYsPES0O7HAb05+SdsJ0OoHLn0jY3k5dKaz1RjuxZU 6Xh7G6IWEKQKPFxVpXSH3Z66MWfhQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudekgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4D8133280059; Tue, 21 Jan 2020 08:39:47 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, Anoob Joseph , Raslan Darawsheh , Xueming Zhang , Alfredo Cardigliano Date: Tue, 21 Jan 2020 14:39:45 +0100 Message-ID: <1850721.kfQNDG1tbD@xps> In-Reply-To: <442B0C2E-A122-40C2-AA90-9F87E125557A@ntop.org> References: <20200121094143.1904095-1-ferruh.yigit@intel.com> <20200121095802.3942052-1-ferruh.yigit@intel.com> <442B0C2E-A122-40C2-AA90-9F87E125557A@ntop.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] net/ionic: ignore missing field initializers warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 21/01/2020 11:01, Alfredo Cardigliano: >=20 > > On 21 Jan 2020, at 10:58, Ferruh Yigit wrote: > >=20 > > The compiler warning is: > > from .../drivers/net/ionic/ionic_dev.c:7: > > .../drivers/net/ionic/ionic_if.h:202:5: note: =E2=80=98rsvd=E2=80=99 de= clared here > > u8 rsvd[62]; > > ^ > >=20 > > This has been observed with gcc 4.8.5, newer 9+ compiler are not giving > > this warning. > >=20 > > Warning is a reminder to the user that there are some fields in the > > struct not initialized with the default value. > > But the C standard clarifies that in that case the field value will be > > zero and code is aware of this behavior, so no initializing to a default > > value is intentional and it is safe to ignore this compiler warning. > >=20 > > Adding '-Wno-missing-field-initializers' compiler flag to disable the > > warning. > >=20 > > Reported-by: Anoob Joseph > > Reported-by: Raslan Darawsheh > > Reported-by: Xueming Zhang > > Signed-off-by: Ferruh Yigit > > --- > > v2: > > * add flag to ionic_lif.c too > > --- > > drivers/net/ionic/Makefile | 3 +++ > > drivers/net/ionic/meson.build | 9 +++++++++ > > 2 files changed, 12 insertions(+) [...] > This looks good to me. Applied, thanks