From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E93DA04A3; Tue, 16 Jun 2020 10:45:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F09111BEA8; Tue, 16 Jun 2020 10:45:53 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id 834FE1BE9E for ; Tue, 16 Jun 2020 10:45:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 13446580222; Tue, 16 Jun 2020 04:45:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 04:45:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= yWzBRF4PSQwmEByBMafcaC521R9Z5L5XvtCMyNnwcNU=; b=EKuF6dPa5dRqE866 vtDxZmwOiNGPiZpiRwvQWWguTAodFu8vv7q2fOIb3UAk7DZrLQBCLC5SLM5T1kDj A/9SwJfbeMZSffI7XL8CiVXL9DkUZinj/QwyRolVLEH1H8bXa+isoVxnmmv0Y0zq XPJ3LLOHfMz+5xDtKES0Nk2MhxbAv14D8Ha9qL88z0mTyIOocAzSSqJSB+BLLHuh R2J2WCNL9D3d5KgQuuWiEhQnLXLnV2hDRRvrBpKMn+yo2OgietROy5kMAjxRd6cO TcIAL7QCQ8veDUAtcEE/RZHKg7dek3j4eHkFHddUa0/uf+HmG128qOwPO/3fQNS1 QO1QKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=yWzBRF4PSQwmEByBMafcaC521R9Z5L5XvtCMyNnwc NU=; b=XbLqf06/77gyv7Dt6NfZmBb9N7bJXtM6ylvMM94i3asnNkNp7d2vYe4Oz KEa51cUqCTqIOCTQVhs2uJQWeCtaGCJgrvER/jwSwT+lqEsRjXEub52aqj0k0WsD GhuDm9y+RgtG3EEeqG+sFXxKgpocxxva6lNxfn66TJLQnpH2dzosSmv1JgyOmngc GvvAdYVq3xOOJfDXHbOZ7eQh1Wg3ghAZMF8K1j5v8j3Q+5y8iqv1gLNrEgK/Z0Cw kGB9IuLnhxyH8kzkVRwerZDYt8UJQ/29Jek077OuhZlm3rPzZGlga1eyIX8j9mYu L4ZviMDVuDQ9ScEmOHcZ3+0rong9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejtddgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F39C328005E; Tue, 16 Jun 2020 04:45:50 -0400 (EDT) From: Thomas Monjalon To: "dmitry.kozliuk@gmail.com" , Tal Shnaiderman Cc: dev@dpdk.org, "pallavi.kadam@intel.com" , "david.marchand@redhat.com" , "olivier.matz@6wind.com" , "ranjit.menon@intel.com" , "navasile@linux.microsoft.com" , Fady Bader , "harini.ramakrishnan@microsoft.com" , "ocardona@microsoft.com" Date: Tue, 16 Jun 2020 10:45:49 +0200 Message-ID: <18516284.rRsmoNJoJ4@thomas> In-Reply-To: References: <20200601093818.5420-1-talshn@mellanox.com> <2493055.5tyvKvVbxn@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 3/4] eal: export needed functions for mbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/06/2020 10:33, Tal Shnaiderman: > > 01/06/2020 11:38, talshn@mellanox.com: > > > From: Tal Shnaiderman > > > > > > Export needed eal functions used by the lib. > > > > > > Signed-off-by: Tal Shnaiderman > > > --- > > > --- a/lib/librte_eal/rte_eal_exports.def > > > +++ b/lib/librte_eal/rte_eal_exports.def > > > @@ -3,6 +3,7 @@ EXPORTS > > > per_lcore__rte_errno > > > rte_calloc > > > rte_calloc_socket > > > + per_lcore__lcore_id > > [...] > > > --- a/lib/librte_eal/rte_eal_version.map > > > +++ b/lib/librte_eal/rte_eal_version.map > > > @@ -394,4 +394,5 @@ EXPERIMENTAL { > > > rte_mem_unmap; > > > __emutls_v.per_lcore__rte_errno; > > > __rte_trace_mem_per_thread_alloc; > > > + __emutls_v.per_lcore__lcore_id; Note the alphabetical order is not respected above. > > I'm surprised about this one in the Linux/BSD map. > > Can it be removed? > > It is needed for the MingGW build which requires the __emutls_v. prefix. We already have per_lcore__lcore_id and per_lcore__rte_errno for Linux and FreeBSD. The prefix __emutls_v. for MinGW looks wrong. If it is really required, it should be added automatically in my opinion. I think we can do it in buildtools/map_to_def.py by adding this prefix to per_lcore__ when required.