From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CD97A0487 for ; Sat, 6 Jul 2019 11:21:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4A4D5689; Sat, 6 Jul 2019 11:21:33 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4207A2C60 for ; Sat, 6 Jul 2019 11:21:32 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B778B20F25; Sat, 6 Jul 2019 05:21:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 06 Jul 2019 05:21:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=uB/jrfL+hs3s9mr2Zh+M0SOpEpJY/y3odNcF9ITm+UU=; b=bb5ymyaXTtMH pUXVwqYKZNlg7sg0qHElRF9fLBuyoDSNYY6olS0srDw3XjiLPrbddYK4mWyiSVPu oyR5DN7SiIMmncoEKeSXgaBsQkT73sSuVJiGO44rMC1RTcO19D+0qBKuvUTkceNF J9PcfMbXRoNN8AJYTdAI5V/kw0a2Lsg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=uB/jrfL+hs3s9mr2Zh+M0SOpEpJY/y3odNcF9ITm+ UU=; b=n/oixL+pRFNbp6quvlgDmSPazhTm9GumOUsWob6C6ZkNFiYIuTeNkrk6l 4i0HykjCmtQuJC2BXCfjR6xd1cY94iedkmh2JgLm2j76H7n70wieHsuTOJV1LaEm BkVyKv+yizvgvvSoVo0oquQ7p8WKelkjIHR6ITpxlMTw7U4MEl1aQb/qmq2o6NCB 3tBQ+ZiwMLFLbb69pjYYBG87R6RAlw/lfqx0O/aFViibcd4kitrxlb3ZXJxyaV0L 8YxGsGM1k+wiEuUkdisRUK+i+0cPBR2NMTXbNkr4NuEVEXISALBFigQZZPVY044K ugX43k8mxDqNeNZKJvFMcpQvbB2Zg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfeeigdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 960E5380087; Sat, 6 Jul 2019 05:21:30 -0400 (EDT) From: Thomas Monjalon To: Jakub Grajciar Cc: dev@dpdk.org, Ferruh Yigit , anatoly.burakov@intel.com Date: Sat, 06 Jul 2019 11:21:28 +0200 Message-ID: <1852664.CeoRc8jZev@xps> In-Reply-To: <2960f303-ac52-de02-6c4f-c5167494a2fa@intel.com> References: <20190702102156.28114-1-jgrajcia@cisco.com> <20190703104408.6953-1-jgrajcia@cisco.com> <2960f303-ac52-de02-6c4f-c5167494a2fa@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] net/memif: zero-copy slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/07/2019 11:20, Ferruh Yigit: > On 7/3/2019 11:44 AM, Jakub Grajciar wrote: > > Zero-copy slave support for memif PMD. > > Slave interface exposes DPDK memory to > > master interface. Only single file segments > > are supported (EAL option --single-file-segments). > > > > Signed-off-by: Jakub Grajciar > > Applied to dpdk-next-net/master, thanks. Sorry, we cannot get this patch in 19.08-rc1 because it is accessing the memory configuration which is now internal: if (!mcfg->single_file_segments) { MIF_LOG(ERR, "Zero-copy doesn't support multi-file segments."); return -ENOTSUP; } We need to find another way of doing this check, or think about avoiding such limitation. Sorry for the inconvenience. PS: While at it, I advise to split your patch. You are moving some functions in a new file and do some changes in the same patch, so it is very hard to understand what are the real changes.