From: Thomas Monjalon <thomas@monjalon.net>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"tredaelli@redhat.com" <tredaelli@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
David Marchand <david.marchand@redhat.com>,
"bluca@debian.org" <bluca@debian.org>,
"Pai G, Sunil" <sunil.pai.g@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: fix detection of static or shared DPDK builds
Date: Wed, 10 Feb 2021 10:25:00 +0100 [thread overview]
Message-ID: <1852982.GJMhToD9Xh@thomas> (raw)
In-Reply-To: <BYAPR11MB381429D8E70FB7644962374FBD8E9@BYAPR11MB3814.namprd11.prod.outlook.com>
09/02/2021 21:10, Pai G, Sunil:
> Hi Bruce,
>
> Thanks for the fix.
> I do see the issue mentioned when using DPDK shared libs with OVS and this patch fixes it.
>
> However, I saw the issue only for system installed DPDK but not for directory installed DPDK.
>
>
> > I saw this issue with OVS, where I was getting weird failures about ports not
> > being bound (in case of physical ports) or not being created (in case of virtio
> > ports), when using a shared build. Since it's potentially serious, I'd appreciate
> > if someone can reproduce the issue and verify the fix so we can consider it
> > for 21.02 inclusion.
> >
> > To demonstrate this with regular DPDK, do a usual build of DPDK and then do
> > "ninja install" to install system-wide. Then build an example app, e.g.
> > l2fwd, using "make" from the examples/l2fwd directory. Running the
> > example normally, e.g. ./build/l2fwd -c F00, leads to no drivers being loaded
> > or ports being found. Adding "-d /path/to/drivers" e.g.
> > "/usr/local/lib/x86_64-linux-gnu/dpdk/pmds-21.1" on my system works as
> > expected. This shows the driver loading is not correct.
> >
> > After applying this patch and re-running "ninja install", l2fwd should run the
> > same with and without the "-d" flag.
> >
> > /Bruce
>
> Tested-by: Sunil Pai G <sunil.pai.g@intel.com>
Applied, thanks
prev parent reply other threads:[~2021-02-10 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 16:33 Bruce Richardson
2021-02-09 12:49 ` Bruce Richardson
2021-02-09 20:10 ` Pai G, Sunil
2021-02-10 9:25 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1852982.GJMhToD9Xh@thomas \
--to=thomas@monjalon.net \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=sunil.pai.g@intel.com \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).