From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id F27453975 for ; Tue, 26 Aug 2014 08:46:22 +0200 (CEST) Received: by mail-we0-f172.google.com with SMTP id x48so14379428wes.31 for ; Mon, 25 Aug 2014 23:50:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4Qlxyl8P8aNO9rOmNTHqLm/W6E9Hb2gSNwmzg4RjZGA=; b=UMF9kKnfqAD5lXqj3/GxOTR/MsJWGK4zmUwU8ioO+AjPTWidZe34o8RvtjzbSuFABz XUwdmMhcdAxNlXeDT83aKViW1utRIr3BGQqf+YVdVAM+RM6ksM1vswe97yxvHlFIcJNg H78IL9/cop9J3BePw4cwg53LUI8eIXxbTehxK9StAV2rZCUm+QguRj8btA7El8hImkzB coZqwSdtDcrPX8Fbn5CYPiyxyPrnW/vJWLQEHPZR+0rY7D88GbrLexxP1StpRfgNe8JR qcWh0r6ANSFvpEfR+H3D0e/N4n0FfBF9XPEeJ0iyr/Sym6VKmS5XN5Ce/6WJugawWPwl X9CA== X-Gm-Message-State: ALoCoQluuiaH7kWEMfDPI6HOePmqKtWcFI1ufGYeqgWFa53d9ooRrAbwE0Q3hrTpsg+j9N2M/4Oe X-Received: by 10.181.8.70 with SMTP id di6mr19718484wid.78.1409035821356; Mon, 25 Aug 2014 23:50:21 -0700 (PDT) Received: from xps13.localnet (1.17.90.92.rev.sfr.net. [92.90.17.1]) by mx.google.com with ESMTPSA id lv7sm8811121wic.16.2014.08.25.23.50.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Aug 2014 23:50:20 -0700 (PDT) From: Thomas Monjalon To: Stephen Hemminger Date: Tue, 26 Aug 2014 08:50:15 +0200 Message-ID: <1854546.3MJ2KxFVuo@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <20140825173359.36a95050@urahara> References: <20140725105037.26769945@haswell.linuxnetplumber.net> <2434669.uPKS10IHqv@xps13> <20140825173359.36a95050@urahara> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vmxnet3: initialize receive mode correctly X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2014 06:46:23 -0000 2014-08-25 17:33, Stephen Hemminger: > Thomas Monjalon wrote: > > 2014-07-25 10:50, Stephen Hemminger: > > > - vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_ALL_MULTI, 1); > > > + vmxnet3_dev_set_rxmode(hw, VMXNET3_RXM_UCAST | VMXNET3_RXM_BCAST, 1); > > > > It's also removing multicast at init. No comment so I assume everybody agrees. > > My general rule is to make all drivers behave the same. I think it's a good rule :) > In DPDK, the ixgbe driver is the "best known" reference. > In that driver "multicast promiscious" is disabled by default. OK, thanks. -- Thomas