From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f176.google.com (mail-we0-f176.google.com [74.125.82.176]) by dpdk.org (Postfix) with ESMTP id E1EDFB347 for ; Fri, 19 Sep 2014 09:47:05 +0200 (CEST) Received: by mail-we0-f176.google.com with SMTP id q58so2039787wes.35 for ; Fri, 19 Sep 2014 00:52:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zWFw0NMYHJcx30z4ItcmfM+cz97qVcbxHY0iqcCZYwk=; b=Ax/WJ812FeBXcrM3yB7qHiKMyVjbyHoIjB6XB8tSHvttEdihRWjqs2XZY/sIE1AxTm ZTJgNtAZxjL3eY9cmBK+wGXGBVresE6I7uRhNnnnbjiCZLTwiDL7F/jV9KdBZqj8keV0 xlW/SzuhPvl6O4HNEWanqkA2iIdgDWi8VaOGCCedDDcxtswSn7aWpRW56MPP9ab1bJ5c tzFaebZjDJGEMe/UVWd+zBCfkrXBbliSnG6lCrzcdYG4pKAOhY0xD3XWp4mkeJCZN6j+ wKfVLxh8rfrZf/p6YW/2RPatL6tDzfQ5AuZ5vn0/ooApdsWZKarqlim5eh+jg8GK+AFd RgAQ== X-Gm-Message-State: ALoCoQk0pjRrxACBdA/T5FBpZPwDA2nCBornv3fijcx4Q2m7ohsxFFmI9fK14dS7b7A3yo0fN9Zw X-Received: by 10.194.187.241 with SMTP id fv17mr10632902wjc.13.1411113175071; Fri, 19 Sep 2014 00:52:55 -0700 (PDT) Received: from xps13.localnet (13.17.90.92.rev.sfr.net. [92.90.17.13]) by mx.google.com with ESMTPSA id p1sm1333723wjy.22.2014.09.19.00.52.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Sep 2014 00:52:54 -0700 (PDT) From: Thomas Monjalon To: David Marchand Date: Fri, 19 Sep 2014 09:52:36 +0200 Message-ID: <1854824.smQoA8XSt0@xps13> Organization: 6WIND User-Agent: KMail/4.13.3 (Linux/3.15.8-1-ARCH; KDE/4.13.3; x86_64; ; ) In-Reply-To: <1410961612-8571-1-git-send-email-david.marchand@6wind.com> References: <1410961612-8571-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 00/20] cleanup logs in main PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Sep 2014 07:47:06 -0000 > Here is a patchset that reworks the log macro in e1000, ixgbe and i40e PMDs. > The idea behind this is to make it easier to debug some init failures and to be > sure of the datapath selected in these PMDs (rx / tx handlers selection). > > The PMDs changes involve adding more debug messages in the default build. > A new eal option has been added to set the default log level, so that you can > render the eal a little less noisy. > > I did not change the default log level for now, as some eal log messages are > marked as DEBUG while being interesting (from my point of view). > I suppose we can change the default log level later once the eal has been > cleaned up. > > Changes since v2: > - just a respin with Jay comments in mind > * don't introduce \n in one commit then remove them > * indent only the impacted parts before removing \n (so split previous patches) > * remove some "" garbage > > Changes since v1: > - continue clean up by always using PMD_*_LOG when logging something in > PMD (i.e. no more printf, RTE_LOG, DEBUGOUT) > - introduce PMD_DRV_LOG_RAW macro for use by shared driver code > - adopt 'second approach': no more \n in PMD_*_LOG callers. This means that we > will enforce a 'no \n' policy in logs for PMD. > > David Marchand (20): > ixgbe: use the right debug macro > ixgbe/base: add a raw macro for use by shared code > ixgbe: indent logs sections > ixgbe: clean log messages > ixgbe: always log init messages > ixgbe: add a message when forcing scatter mode > ixgbe: add log messages when rx bulk mode is not usable > i40e: use the right debug macro > i40e/base: add a raw macro for use by shared code > i40e: indent logs sections > i40e: clean log messages > i40e: always log init messages > i40e: add log messages when rx bulk mode is not usable > e1000: use the right debug macro > e1000/base: add a raw macro for use by shared code > e1000: indent logs sections > e1000: clean log messages > e1000: always log init messages > e1000: add a message when forcing scatter mode > eal: set log level from command line Applied for version 1.8.0. Thanks -- Thomas