From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com (mailout4.w1.samsung.com [210.118.77.14]) by dpdk.org (Postfix) with ESMTP id AA8FD2B98; Wed, 12 Oct 2016 15:24:58 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OEX007XMRXKYV10@mailout4.w1.samsung.com>; Wed, 12 Oct 2016 14:24:57 +0100 (BST) Received: from eusmges3.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20161012132456eucas1p241b8da9712570c9c1e248a1453d468a9~8y6cjAnPv2849128491eucas1p27; Wed, 12 Oct 2016 13:24:56 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3.samsung.com (EUCPMTA) with SMTP id 94.62.11330.8A93EF75; Wed, 12 Oct 2016 14:24:56 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20161012132455eucas1p1dff4dbb3c776b77bdd668144d16e066c~8y6b0oKEs0124601246eucas1p1Q; Wed, 12 Oct 2016 13:24:55 +0000 (GMT) X-AuditID: cbfec7f2-f79556d000002c42-c8-57fe39a8949e Received: from eusync4.samsung.com ( [203.254.199.214]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 12.0E.10494.1893EF75; Wed, 12 Oct 2016 14:24:17 +0100 (BST) Received: from [106.109.129.180] by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OEX00ADLRXIO110@eusync4.samsung.com>; Wed, 12 Oct 2016 14:24:55 +0100 (BST) To: Eric Kinzie Cc: dev@dpdk.org, Declan Doherty , Heetae Ahn , Yuanhan Liu , Bernard Iremonger , stable@dpdk.org, Thomas Monjalon From: Ilya Maximets Message-id: <1854c9f5-eedf-fc7b-a786-7526b80b6efa@samsung.com> Date: Wed, 12 Oct 2016 16:24:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <20161007020225.GA22829@roosta.home> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprHKsWRmVeSWpSXmKPExsWy7djP87orLP+FG3R08ltsbhS2ePOgicXi 3aftTBbzTu1lt5j2+Ta7xZX2n+wW/zr+sFt82TSdzeL6hAusDpweF/vvMHr8WrCU1WPnrLvs Hov3vGTymHcy0KNvyyrGALYoLpuU1JzMstQifbsErowf1/+wFxwVr7h0ZTF7A+NK4S5GDg4J AROJ1p3mXYycQKaYxIV769m6GLk4hASWMkrMfHsHyvnMKLFv0hkmiCoTiZ+vt7CB2EICyxgl 1r7VgCh6wSjR9OoGI0hCWMBL4veb7SwgtoiAisT3vdtZQYqYBZqYJN4vuM8KkmAT0JE4tfoI WAOvgJ3EjbZpYFNZBFQlls2fzgZynqhAhMTuu6kQJYISPybfA5vJKWAo8fzdOzCbWcBAYsaU w0wQtrzE5jVvmUF2SQhsY5e48v02K8SbshKbDjBDPOAice/AKhYIW1ji1fEt7BC2jMTlyd1Q 8WqJiVvb2CHmtDBKLJz4gxUiYS9x6uZVqGV8EpO2TWeGmM8r0dEmBFHiIfFj12uoOY4SN64/ Y4EE0EFGiT/T7zNOYJSfheSfWUh+mIXkhwWMzKsYRVJLi3PTU4uN9YoTc4tL89L1kvNzNzEC U83pf8c/7WD8esLqEKMAB6MSD6/A1z/hQqyJZcWVuYcYJTiYlUR4pSz+hQvxpiRWVqUW5ccX leakFh9ilOZgURLn3bPgSriQQHpiSWp2ampBahFMlomDU6qB0f/w/D0XLaN+3PR/sea3pmFN PxdTtMOCuVNYpBP+vZ+acUOl+SPTtbMuXfxp98v3FtdvSA2SOfB1z6+lNgbbcvLLziwsapBT 7fkiJDjpWe7yRftefmz69NnYicPG4XtwTqfcGt2HC34FXFE4nrX5RUTRzhWfOmMnNK90YDm7 NlFxzrHOT0cnX1BiKc5INNRiLipOBAB8dCRPMQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t/xa7qNlv/CDbaeEbTY3Chs8eZBE4vF u0/bmSzmndrLbjHt8212iyvtP9kt/nX8Ybf4smk6m8X1CRdYHTg9LvbfYfT4tWApq8fOWXfZ PRbvecnkMe9koEffllWMAWxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4h QUoKZYk5pUCekQEacHAOcA9W0rdLcMv4cf0Pe8FR8YpLVxazNzCuFO5i5OSQEDCR+Pl6CxuE LSZx4d56IJuLQ0hgCaPE9/+XGSGcF4wSn8+uZgGpEhbwkvj9ZjuYLSKgIvF973ZWiKKDjBJt Vx6zgySYBVqYJPrn6oDYbAI6EqdWH2EEsXkF7CRutE0DW8cioCqxbP50MFtUIELi1qqPUDWC Ej8m3wNbwClgKPH83TsgmwNopp7E/YtaEOPlJTavecs8gVFgFpKOWQhVs5BULWBkXsUoklpa nJueW2ykV5yYW1yal66XnJ+7iREYd9uO/dyyg7HrXfAhRgEORiUeXoGvf8KFWBPLiitzDzFK cDArifBKWfwLF+JNSaysSi3Kjy8qzUktPsRoCvTCRGYp0eR8YErIK4k3NDE0tzQ0MrawMDcy UhLnnfrhSriQQHpiSWp2ampBahFMHxMHp1QDo69G4cFaYQe99xs7zzS+/nVn15sl8qVJ6U6h dr5HPLk47JUnXv5TwPqvfrb5he1Rl57xckwwKP/6WzEor6i9j//Mt6Vyf7125c+Myebd7dly 5MWLTfaXhL/t8Jhgs9Djv/STcK4tvb98VnbL2sZ/mf1w/pFPTmyR5t+lrR6y9Gy8Of8h9ymX nUosxRmJhlrMRcWJALguZ73RAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161012132455eucas1p1dff4dbb3c776b77bdd668144d16e066c X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G+yCvOyEseyghOyekBtFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?SWx5YSBNYXhpbWV0cxtTUlItVmlydHVhbGl6YXRpb24gTGFi?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbRW5naW5lZXI=?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161007020239eucas1p296376eaefe32f6b8661c4287e26d48cd X-RootMTR: 20161007020239eucas1p296376eaefe32f6b8661c4287e26d48cd References: <1473251290-22053-1-git-send-email-i.maximets@samsung.com> <20161007020225.GA22829@roosta.home> Subject: Re: [dpdk-dev] [PATCH] Revert "bonding: use existing enslaved device queues" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 13:24:58 -0000 On 07.10.2016 05:02, Eric Kinzie wrote: > On Wed Sep 07 15:28:10 +0300 2016, Ilya Maximets wrote: >> This reverts commit 5b7bb2bda5519b7800f814df64d4e015282140e5. >> >> It is necessary to reconfigure all queues every time because configuration >> can be changed. >> >> For example, if we're reconfiguring bonding device with new memory pool, >> already configured queues will still use the old one. And if the old >> mempool be freed, application likely will panic in attempt to use >> freed mempool. >> >> This happens when we use the bonding device with OVS 2.6 while MTU >> reconfiguration: >> >> PANIC in rte_mempool_get_ops(): >> assert "(ops_index >= 0) && (ops_index < RTE_MEMPOOL_MAX_OPS_IDX)" failed >> >> Cc: >> Signed-off-by: Ilya Maximets >> --- >> drivers/net/bonding/rte_eth_bond_pmd.c | 10 ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c >> index b20a272..eb5b6d1 100644 >> --- a/drivers/net/bonding/rte_eth_bond_pmd.c >> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c >> @@ -1305,8 +1305,6 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, >> struct bond_rx_queue *bd_rx_q; >> struct bond_tx_queue *bd_tx_q; >> >> - uint16_t old_nb_tx_queues = slave_eth_dev->data->nb_tx_queues; >> - uint16_t old_nb_rx_queues = slave_eth_dev->data->nb_rx_queues; >> int errval; >> uint16_t q_id; >> >> @@ -1347,9 +1345,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, >> } >> >> /* Setup Rx Queues */ >> - /* Use existing queues, if any */ >> - for (q_id = old_nb_rx_queues; >> - q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { >> + for (q_id = 0; q_id < bonded_eth_dev->data->nb_rx_queues; q_id++) { >> bd_rx_q = (struct bond_rx_queue *)bonded_eth_dev->data->rx_queues[q_id]; >> >> errval = rte_eth_rx_queue_setup(slave_eth_dev->data->port_id, q_id, >> @@ -1365,9 +1361,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev, >> } >> >> /* Setup Tx Queues */ >> - /* Use existing queues, if any */ >> - for (q_id = old_nb_tx_queues; >> - q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) { >> + for (q_id = 0; q_id < bonded_eth_dev->data->nb_tx_queues; q_id++) { >> bd_tx_q = (struct bond_tx_queue *)bonded_eth_dev->data->tx_queues[q_id]; >> >> errval = rte_eth_tx_queue_setup(slave_eth_dev->data->port_id, q_id, >> -- >> 2.7.4 >> > > NAK > > There are still some users of this code. Let's give them a chance to > comment before removing it. Hi Eric, Are these users in CC-list? If not, could you, please, add them? This patch awaits in mail-list already more than a month. I think, it's enough time period for all who wants to say something. Patch fixes a real bug that prevent using of DPDK bonding in all applications that reconfigures devices in runtime including OVS. Best regards, Ilya Maximets.