From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C49A0032; Fri, 1 Oct 2021 17:34:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C9EC4118A; Fri, 1 Oct 2021 17:34:45 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 6D49F4067A for ; Fri, 1 Oct 2021 17:34:43 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E6CCA5C010E; Fri, 1 Oct 2021 11:34:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 01 Oct 2021 11:34:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= DeGvRAIVxBXqs4kPnXXaKk5b4j/Uk7Et+YGgQyuJFmc=; b=beyE0i4TB1TYF3T0 1kJlDX9KqQuYquF7CR5e3b36qb3hPuVq4/MajKF3jlIdWf8Klk2YtZgB0qqfGMrG nLimJuotz0XgIhT2jz8n0am5BueJphohspd5VF9/TjMWA7BeXKJCM4l3tHATJsoA CMoqWtbubN6p/5gtPN5Ar//rOtrmhrPS/agX+srV3H3KICjTnE33GGlJBDmGA4+L ct1si5g7v/MLelRKrwelEPmOUg7SBDNjgIJcNHkThBD8xU2C4dH+SgCVisiWY9ea wJLHUB0YZl25SZJy0D1bGoC5ZqojNoxPbKzntFKSpqLikO/zTw1PWE4rEsNs/cio GqJAnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=DeGvRAIVxBXqs4kPnXXaKk5b4j/Uk7Et+YGgQyuJF mc=; b=jjItCXX1ll766xgUtZo/cgfOIMBrBd7RsvRIc6W9Kwde9qtuUhqTl0qdZ VRFQ8DLSqWJkpKjqhWDflJfXoUvnoxbMttm0R64Vhh1PqTGLwgEbEWmMeLmYjZc2 E0iQwvnF7L9eBkvys4tSU6xo0B4YmNUGJLCsaronbPkQypl3d80lIoUaQ51rLSk+ G3zm5GC2YPFzJ5bce90+HgHu1T3EjH4DOvz7bN1q/QoKbrONd1O8xtInb8omzUUF nZo3KKrfxOxsATpFjxXHEt/4drsZI5xaTeZNFj/Ib3vEErCJiTAUn79IPqm1t24h f4H4U5smFfaApkVGc/UHCn3mKnCFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekiedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepueevgfegieeuvefhkefggeffieehtdeukeehgfejteekhfevheeh iedvtdehgfeunecuffhomhgrihhnpeguphgukhdrohhrghdpughpughkqdhtvghlvghmvg htrhihrdhphienucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Oct 2021 11:34:42 -0400 (EDT) From: Thomas Monjalon To: "Richardson, Bruce" Cc: "dev@dpdk.org" , "Hunt, David" , "Power, Ciara" Date: Fri, 01 Oct 2021 17:34:40 +0200 Message-ID: <18560200.KvGdsqrn6O@thomas> In-Reply-To: References: <20210913105137.130097-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/3] improvements for telemetry script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > >Patch 1 fixes errors reported by flake8 in the telemetry python script. > >Inspired by the work by Dave Hunt [1] the final two patches look to adjust the > >script so that it works nicer when commands come from an input pipe rather > >than from an interactive terminal. > > > >Without this set: > > $ echo "/eal/params" | ./usertools/dpdk-telemetry.py > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > > {"version": "DPDK 21.11.0-rc0", "pid": 130033, "max_output_len": 16384} > > Connected to application: "dpdk-test" > > --> {"/eal/params": ["./build/app/test/dpdk-test", "-c", "F", "--no-huge"]} > > --> Traceback (most recent call last): > > File "/home/bruce/dpdk.org/./usertools/dpdk-telemetry.py", line 109, in > > > > handle_socket(os.path.join(rdir, > >'dpdk_telemetry.{}'.format(TELEMETRY_VERSION))) > > File "/home/bruce/dpdk.org/./usertools/dpdk-telemetry.py", line 78, in > >handle_socket > > text = input('--> ').strip() > > EOFError: EOF when reading a line > > > >With this patchset: > > $ echo "/eal/params" | ./usertools/dpdk-telemetry.py > > {"/eal/params": ["./build/app/test/dpdk-test", "-c", "F", "--no-huge"]} > > > > > >[1] http://patches.dpdk.org/project/dpdk/patch/20210909155625.24581-1- > >david.hunt@intel.com/ > > > >Bruce Richardson (3): > > usertools/dpdk-telemetry: fix flake8 errors > > usertools/dpdk_telemetry: fix handling EOF for input pipe > > usertools/dpdk-telemetry: silence prompts for input pipes > > For the series, > Acked-by: Ciara Power Applied, thanks.