From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Lin, Xueqin" <xueqin.lin@intel.com>,
"Peng, ZhihongX" <zhihongx.peng@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] pipeline: remove unreachable branch
Date: Thu, 04 Nov 2021 18:20:50 +0100 [thread overview]
Message-ID: <1857008.8GTJABRhPr@thomas> (raw)
In-Reply-To: <DM8PR11MB5670213526A311FD10C9D9A1EB8C9@DM8PR11MB5670.namprd11.prod.outlook.com>
> > A previous change blamed it on compiler/ASan, while this is a real
> > (yet minor) issue.
> >
> > This return -EINVAL is never reached since we test all combinations of
> > fidx and fcin booleans.
> > All branches end up with a return 0, factorize them.
> >
> > Fixes: 84f5ac9418ea ("pipeline: fix build with ASan")
> > Fixes: f38913b7fb8e ("pipeline: add meter array to SWX")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Applied, thanks
prev parent reply other threads:[~2021-11-04 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 6:56 David Marchand
2021-11-03 12:55 ` Dumitrescu, Cristian
2021-11-04 17:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1857008.8GTJABRhPr@thomas \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=xueqin.lin@intel.com \
--cc=zhihongx.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).