From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEA5BA0C5A; Thu, 4 Nov 2021 18:20:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1B5C41223; Thu, 4 Nov 2021 18:20:57 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id F3B42411C9 for ; Thu, 4 Nov 2021 18:20:55 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B2DF932002E2; Thu, 4 Nov 2021 13:20:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 04 Nov 2021 13:20:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= wpYEa3CPqkOW0fAEEsnmozUWd7K1v8QRa4Lrevrd784=; b=JINGO1lOZfjiQHXt ABYu13+bleyIIs+AQVlz5Kgc5qx9zYVsuMevVf3y53CfCE4lsXdeztdYIqiVtiGV 06E8gK9TjvTvCu+9fAbcFubrJzIYcj7Wg+ZiM/0CG+QIZLKJJJJXGWsohWmgMmcp nqAjZdePw7FgLdbrCQxjfMe3lHLw+1ri7Tb/kFW/Dd8NnaJc6AJ3FIL+kkaKZb+L HZKfr+neWx8006Xp+lcj3PTyy6BhehoSPnyzb1j739titwWr+ShJL+rvwXvLhxuN 3lmbAMLNM7Fxt6sXO3oa/jumraKMqPNXuRYHNRy81qortHCg80MQSi54F0JGduFg Sq5b7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wpYEa3CPqkOW0fAEEsnmozUWd7K1v8QRa4Lrevrd7 84=; b=bSBoJjFjy2R2hIQbrQ11yaw5lqqATk7ny/qf+uiY55xAG8KMAqe9Chif/ gGIWpHMPbw9MktSR8dqVEovgpAB22gw2nt1nW79U4l7xRUVsiwEV4JWSg9Ibjabz FSkE/d+aBilEMYXl46fe1/uUJmaYNQrqPDezOHVJWeI+jL3ePnObFBw0+3OEbXyR UhS1ubLPszhQ9raBxj9EAyMQvaEjN9o9e2DcJG9GLwa9jzMmvj/lu25mXUV7QUR2 jJORyI81uJe9AOCvervsN2b20PMLaPU3DM+0aUKP/Xg94nmxoZE/6vBVIG2aQ+ne 3TT9k1kqkowothpWSGr99I51ze8zw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeggdelhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Nov 2021 13:20:52 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: "dev@dpdk.org" , "Lin, Xueqin" , "Peng, ZhihongX" , "Dumitrescu, Cristian" Date: Thu, 04 Nov 2021 18:20:50 +0100 Message-ID: <1857008.8GTJABRhPr@thomas> In-Reply-To: References: <20211103065658.8100-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pipeline: remove unreachable branch X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > A previous change blamed it on compiler/ASan, while this is a real > > (yet minor) issue. > > > > This return -EINVAL is never reached since we test all combinations of > > fidx and fcin booleans. > > All branches end up with a return 0, factorize them. > > > > Fixes: 84f5ac9418ea ("pipeline: fix build with ASan") > > Fixes: f38913b7fb8e ("pipeline: add meter array to SWX") > > > > Signed-off-by: David Marchand > > Acked-by: Cristian Dumitrescu Applied, thanks