DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, "Bernal Marin, Miguel" <miguel.bernal.marin@intel.com>
Subject: Re: [dpdk-dev] Headers files with BSD license in kernel
Date: Wed, 10 Jun 2015 11:08:24 +0200	[thread overview]
Message-ID: <1857272.JbxJmyvPRA@xps13> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E4512369780CAB547@IRSMSX109.ger.corp.intel.com>

2015-06-10 09:01, Burakov, Anatoly:
> > 2015-06-10 01:20, Zhang, Helin:
> > > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > I'm working on Clear Linux project, and when I was integrating
> > > > > > > DPDK kernel modules to our kernel I found there are two
> > > > > > > headers with BSD License
> > > > > > >
> > > > > > > rte_pci_dev_feature_defs.h
> > > > > > > rte_pci_dev_features.h
> > > > > > >
> > > > > > > those are included in igb_uio module.
> > > > > > >
> > > > > > > Are those licenses correct?
> > > >
> > > > You can always escalate a BSD license to GPL, but the other way is not
> > allowed.
> > > > Ideally, the language on the file should make it clear that it is dual
> > licensed.
> > > > In an ideal world, igb_uio would go away, I am working on that.
> > >
> > > Yes, I agree with you. To be clearer, rte_pci_dev_feature_defs.h
> > > should be in dual liceses, and rte_pci_dev_features.h should be in GPL
> > license.
> > 
> > Yes, it is an error from this commit:
> > 	http://dpdk.org/browse/dpdk/commit/?id=88701645c98c9c88
> > These definitions were moved from a GPL file so they should keep the GPL
> > header.
> > Then it is used in EAL:
> > 	http://dpdk.org/browse/dpdk/commit/?id=ff0b67d1c868c19
> > So it must be dual licensed, like for rte_pci_dev_ids.h:
> > 	http://dpdk.org/browse/dpdk/tree/lib/librte_eal/common/include/
> > rte_pci_dev_ids.h
> 
> Agreed, should have been more careful. Should I make the patch to correct this?

You are welcome :)

      reply	other threads:[~2015-06-10  9:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 17:40 Miguel Bernal Marin
2015-06-09 20:09 ` Miguel Bernal Marin
2015-06-10  0:42   ` Zhang, Helin
2015-06-10  1:15     ` Stephen Hemminger
2015-06-10  1:20       ` Zhang, Helin
2015-06-10  8:54         ` Thomas Monjalon
2015-06-10  9:01           ` Burakov, Anatoly
2015-06-10  9:08             ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1857272.JbxJmyvPRA@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=miguel.bernal.marin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).