From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E6AE5A04BB;
Tue, 6 Oct 2020 23:33:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 9C9672B8B;
Tue, 6 Oct 2020 23:33:48 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9327A2B8B;
Tue, 6 Oct 2020 23:33:45 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 440895C00E6;
Tue, 6 Oct 2020 17:33:44 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Tue, 06 Oct 2020 17:33:44 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
eYBcOWNbsmO/vly5DGTuR86p/+WFvyYLdTK+am4kO2U=; b=QGBrU8AbVL6UbZ7I
hvuuqvH/LpKFJvn1zMLXfFkwKZ1usN/BKpOIhhsyxTSe/4pYW4oiks/U1eHnmJEi
cieD62BMGr7Uiv74VAdTEkJLZQg373XZKbQAEYqQ9tXELmOC1uBdinxM1xPX4itI
vPxvxP4uSyY2CxY8c3sOSyuSLfYocxwvfZ8yBT7CdlRINwRJuoCJ5QbYskFHc+7j
9eQmhNuuK34Qw7zGvA612QVfFLdd3aBhToYbJxKlF8sks/VRbbKD2QA0r3RmiLLi
KcbZaTTIPGodaTNNVA6zWP/JTHv7KCZv1yr7yCBlzk2O7eg+mhB2EHBd/sNdf5J7
R26ucA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=eYBcOWNbsmO/vly5DGTuR86p/+WFvyYLdTK+am4kO
2U=; b=qbclqMhX1vdTRHbLuxrk4Gvzq0zPMj8D58qogwM8VQajRdPsfuEqVQSoz
lbofRXmGiyhFyPxsYI3AwoJX0l0AQinR3L/U47/yhe4J6ifdBfevNlmBAw4kUwCR
zxqkzg5PxyyZbmzjS4vv6bMUvyc3fUsR4vnXp1uHPIXoB0WqruA3OxvYJ0knjLIL
37ca6UUNaEFM9mr/Q/wk4ILlQStcaaHsvvaHcoUmHXP8m2BxEp9O2VEZL+AWguDl
6vQnxxYcWwuFEhrYuuR+KHxTFkceFW+Z2ZfjcPdSt3YAj2xaRYZDf8gTy4BQQNGO
h0cNtJF+PfAJ3+Ztd5fWjrAiF3uQA==
X-ME-Sender: <xms:t-J8X5axODspbaVGs0EzSxEGBS-9bol1K2CC5YtBdxgo1y5CwjLstQ>
<xme:t-J8XwZ97jjbNrPRImem9zuveVkfQuvzBXKDV-FG4urXfCpjrouh6AlXQT3laUUSO
2spM6CRaH8yFOHSiQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrgeeggdduheelucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu
ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf
hiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl
ohhnrdhnvght
X-ME-Proxy: <xmx:t-J8X7_3xu7yUV8RposZrdbR4ozaIfnRLeamxIO6PYnz8TtLJ8yxVQ>
<xmx:t-J8X3qCRLjXq7eJ59MJ7Kn2d7Bz06Fh2I6i1p0Ou2wC9Kq7iFBn3A>
<xmx:t-J8X0ruIFNKjrfKLAn9LPhwK-UFKFLiLn2tg23jqdCr67ZRvGb3zg>
<xmx:uOJ8X9kKKy8SjRW5gdPAdx59-ozLBUq_EpS-U6bKkIQvjMkjdA_X7g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 44DB53064610;
Tue, 6 Oct 2020 17:33:42 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: nipun.gupta@nxp.com
Cc: dev@dpdk.org, jerry.lilijun@huawei.com, xudingke@huawei.com,
Yunjian Wang <wangyunjian@huawei.com>, stable@dpdk.org,
wangyunjian <wangyunjian@huawei.com>, hemant.agrawal@nxp.com
Date: Tue, 06 Oct 2020 23:33:41 +0200
Message-ID: <1857423.J520cpIJeM@thomas>
In-Reply-To: <1599613906-19420-1-git-send-email-wangyunjian@huawei.com>
References: <8f778cef6a01a8222e256daf25ff5ce6feed334b.1599485594.git.wangyunjian@huawei.com>
<1599613906-19420-1-git-send-email-wangyunjian@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Nipun, could you review please?
09/09/2020 03:11, wangyunjian:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This issue detected by coverity, CID#279443(Structurally dead code).
>
> Coverity issue: 279443
> Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2: fix spelling in commit log
> ---
> drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> index 0b9c4e3d7..4b8474951 100644
> --- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> +++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
> @@ -452,9 +452,10 @@ rte_qdma_reset(void)
> /* In case there are pending jobs on any VQ, return -EBUSY */
> for (i = 0; i < qdma_dev.max_vqs; i++) {
> if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
> - qdma_vqs[i].num_dequeues))
> + qdma_vqs[i].num_dequeues)) {
> DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
> return -EBUSY;
> + }
> }
>
> /* Reset HW queues */
>