From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options
Date: Fri, 05 Dec 2014 22:14:52 +0100 [thread overview]
Message-ID: <1857540.S8Y96DUbY1@xps13> (raw)
In-Reply-To: <128892442.7P4I1l0Tzy@xps13>
2014-12-05 17:37, Thomas Monjalon:
> 2014-12-05 11:24, John W. Linville:
> > On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote:
> > > Hi John,
> > >
> > > 2014-12-04 16:42, John W. Linville:
> > > > This allows the PMD to compile with kernels that don't support the
> > > > options in question. The "#if defined(...)" lines are a bit ugly,
> > > > but I don't know of any better way to accomplish the task.
> > > >
> > > > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > > > ---
> > > > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16 ++++++++++++----
> > > > 1 file changed, 12 insertions(+), 4 deletions(-)
> > >
> > > Is it possible to enable compilation of this PMD in default configuration?
> > > I guess it shouldn't fail anymore with this patch?
> >
> > Yes, I believe so. I checked the kernel git history for when each
> > definition was included. Everything else was older than the 2.6.32
> > kernel.
> >
> > I think you can reenable this PMD in the common_linuxapp config file
> > if you like. I'll send a patch if you prefer for me to do so.
>
> OK, I'm going do it.
Applied with default config change to enable the PMD.
Thanks
--
Thomas
prev parent reply other threads:[~2014-12-05 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 21:42 John W. Linville
2014-12-05 3:46 ` Neil Horman
2014-12-05 9:30 ` Thomas Monjalon
2014-12-05 16:24 ` John W. Linville
2014-12-05 16:37 ` Thomas Monjalon
2014-12-05 17:29 ` [dpdk-dev] Accessing Virtual Function Device on Guest Machine using VFIO Aashima Arora
2014-12-05 18:08 ` Thomas Monjalon
2014-12-05 18:42 ` Neil Horman
2014-12-05 21:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1857540.S8Y96DUbY1@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).