Re: [dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2014-12-05 17:37, Thomas Monjalon:
> 2014-12-05 11:24, John W. Linville:
> > On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote:
> > > Hi John,
> > > 
> > > 2014-12-04 16:42, John W. Linville:
> > > > This allows the PMD to compile with kernels that don't support the
> > > > options in question.  The "#if defined(...)" lines are a bit ugly,
> > > > but I don't know of any better way to accomplish the task.
> > > > 
> > > > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > > > ---
> > > >  lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16 ++++++++++++----
> > > >  1 file changed, 12 insertions(+), 4 deletions(-)
> > > 
> > > Is it possible to enable compilation of this PMD in default configuration?
> > > I guess it shouldn't fail anymore with this patch?
> > 
> > Yes, I believe so.  I checked the kernel git history for when each
> > definition was included.  Everything else was older than the 2.6.32
> > kernel.
> > 
> > I think you can reenable this PMD in the common_linuxapp config file
> > if you like.  I'll send a patch if you prefer for me to do so.
> 
> OK, I'm going do it.

Applied with default config change to enable the PMD.

Thanks
-- 
Thomas