From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id 2AB9A7E75 for ; Fri, 5 Dec 2014 22:15:18 +0100 (CET) Received: by mail-wi0-f178.google.com with SMTP id em10so2655442wid.17 for ; Fri, 05 Dec 2014 13:15:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=6q31Op3aA6C79uPlxOU+T0YcROXmX2dYQrQWK3ef+JA=; b=A3hUZsRcGb6oxRe5uGkrOCDtowWecFcB51YyKvCvy+ww7vv/XqNDbNDDwTDTRoEdh4 0Ko6+2xMfperD0UTO3vey4Jj8aaPGQK1oAJE9uSpzzFzKFjgt8cRAgsoU/P9RugAzSOw NFX9eLzE9noKUszPAD/sR2lLr95CUJMHJDQGLUJ6+UxR/3jc3uWzZ9NwZKr8rZ8qIeTU BT+CVc7ubbYdZpJkgTAYGkdVvFqOAuQ7cGbUX6SXVOj7KC2SmtUGY25vBoHkxkwxj10P djynMLJMHY1x1XWDYAqwRCue/ijBnuyL+9v6z7lKk37lS2M+hsa/ET7gv2DKqwuiivcC HPLQ== X-Gm-Message-State: ALoCoQmY8hi7DpOkfE8/oo2TvQDszRO7Og3YLu3gYTdoBmOvMCq2CZfJRR++YwFALfp4pyYvDu7i X-Received: by 10.194.77.233 with SMTP id v9mr26925729wjw.24.1417814117941; Fri, 05 Dec 2014 13:15:17 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id d5sm46338026wjb.34.2014.12.05.13.15.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 13:15:17 -0800 (PST) From: Thomas Monjalon To: "John W. Linville" Date: Fri, 05 Dec 2014 22:14:52 +0100 Message-ID: <1857540.S8Y96DUbY1@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <128892442.7P4I1l0Tzy@xps13> References: <1417729325-9410-1-git-send-email-linville@tuxdriver.com> <20141205162453.GB28319@tuxdriver.com> <128892442.7P4I1l0Tzy@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] librte_pmd_af_packet: add compile-time checks for kernel-specific options X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Dec 2014 21:15:18 -0000 2014-12-05 17:37, Thomas Monjalon: > 2014-12-05 11:24, John W. Linville: > > On Fri, Dec 05, 2014 at 10:30:53AM +0100, Thomas Monjalon wrote: > > > Hi John, > > > > > > 2014-12-04 16:42, John W. Linville: > > > > This allows the PMD to compile with kernels that don't support the > > > > options in question. The "#if defined(...)" lines are a bit ugly, > > > > but I don't know of any better way to accomplish the task. > > > > > > > > Signed-off-by: John W. Linville > > > > --- > > > > lib/librte_pmd_af_packet/rte_eth_af_packet.c | 16 ++++++++++++---- > > > > 1 file changed, 12 insertions(+), 4 deletions(-) > > > > > > Is it possible to enable compilation of this PMD in default configuration? > > > I guess it shouldn't fail anymore with this patch? > > > > Yes, I believe so. I checked the kernel git history for when each > > definition was included. Everything else was older than the 2.6.32 > > kernel. > > > > I think you can reenable this PMD in the common_linuxapp config file > > if you like. I'll send a patch if you prefer for me to do so. > > OK, I'm going do it. Applied with default config change to enable the PMD. Thanks -- Thomas