From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: zzang <zhida.zang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: support of link flow control
Date: Thu, 13 Nov 2014 10:46:57 +0100 [thread overview]
Message-ID: <1858688.dTAFT58TFH@xps13> (raw)
In-Reply-To: <1411888086-10818-1-git-send-email-zhida.zang@intel.com>
Hi Zhida,
> Add support of link flow control.
>
> Signed-off-by: Zhida Zang <zhida.zang@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
I think you are reworking this patch, right?
I won't review it myself because I don't i40e enough.
I just have some minor comments:
> +static int i40e_10g_fc_enable(struct i40e_hw *hw, uint16_t pause_time)
"static int" should be on a separate line.
> + PMD_INIT_LOG(ERR, "i40e_set_fc = %d\n", err);
Carriage return is already included in PMD_INIT_LOG now.
Thanks for keep us informed of the status of this patch.
--
Thomas
prev parent reply other threads:[~2014-11-13 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 7:08 zzang
2014-11-13 9:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1858688.dTAFT58TFH@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=zhida.zang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).