From: Thomas Monjalon <thomas@monjalon.net>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup
Date: Tue, 15 Jan 2019 11:10:37 +0100 [thread overview]
Message-ID: <1859916.dnCeAC13tB@xps> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A4009E2@irsmsx110.ger.corp.intel.com>
15/01/2019 11:09, Pattan, Reshma:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 11/01/2019 18:51, Reshma Pattan:
> > > Virtual devices added in pdump application using rte_eal_hotplug_add
> > > should be removed explicitly while existing the pdump application,
> > > otherwise the
> >
> > existing -> exiting ?
> >
> > > subsequent run of the pdump application will fail with the reason that
> > > virtual devices with the same name already exists in primary.
> > >
> > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev
> > > attach")
> > > CC: stable@dpdk.org
> > > CC: ferruh.yigit@intel.com
> >
> > Why is it marked as a fix of this commit?
> > Is it a miss in the conversion from ethdev attach calls?
> > Or a changed behaviour with hotplug functions?
>
> It is changed behaviour with hotplug functions.
Please, could you explain?
next prev parent reply other threads:[~2019-01-15 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 17:41 [dpdk-dev] [PATCH v2] " Reshma Pattan
2019-01-11 17:51 ` [dpdk-dev] [PATCH v3] " Reshma Pattan
2019-01-15 0:59 ` Thomas Monjalon
2019-01-15 10:09 ` Pattan, Reshma
2019-01-15 10:10 ` Thomas Monjalon [this message]
2019-01-15 10:25 ` Pattan, Reshma
2019-01-17 20:23 ` Thomas Monjalon
2019-01-15 13:45 ` [dpdk-dev] [PATCH v4] " Reshma Pattan
2019-01-15 14:57 ` Ferruh Yigit
2019-01-17 20:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1859916.dnCeAC13tB@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).