From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 276535F24; Tue, 15 Jan 2019 11:10:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B40C527531; Tue, 15 Jan 2019 05:10:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 15 Jan 2019 05:10:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4W30JVPxns3fsq/0hSxrgRhZGrpLY4D820GVKk21ROw=; b=O5Y9TNyPf28Q 8QttO/OuQd1F0T9irTvsqig9VQDWHfTrQ+sxxxPpl84I5r/0BWfU4ZIqoXOCmjCY hM7E7nBDcHhngbuFX3XpjbI/McRWuTknUOo8wAmGmOmVmUm+fUu5hrAkN0PMrGJ4 +7KEbtnJP4xBDxaYtAu0CxB+10ZuYKw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4W30JVPxns3fsq/0hSxrgRhZGrpLY4D820GVKk21R Ow=; b=R50kJLYXb4Vubq/tto5ODMoGan0nETPnl03otKjAxOklkkNx8nEYC+8IL Xd6QY7/QrC9TcCQ/BX/imREGpOA1qFKSKLBryaLJIgQmCJGg8gDeqpWI1AcRty8J h8Kvgzn2YAUUyVe5yh4kimbVEihIf0vJf0x85ddhnrL5ZhGnSZC7ZKKoFuh40PEP dgyLO4CqtlGcwxcnTI4otHFmkYvWxbaOmC97FYIcE/poOiXeAn40/WQbssBZsFc1 9tQ1jZ5JoctS2UA81vIjHnf2XaStQi+mUN/7jmsMMT6HSvmj7h4yl8KTrnJYsxFl uYHfkQmaR7n/48JWCyG6odSmSkvgw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgeefgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 498AA100B8; Tue, 15 Jan 2019 05:10:38 -0500 (EST) From: Thomas Monjalon To: "Pattan, Reshma" Cc: "dev@dpdk.org" , "stable@dpdk.org" , "Yigit, Ferruh" Date: Tue, 15 Jan 2019 11:10:37 +0100 Message-ID: <1859916.dnCeAC13tB@xps> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A4009E2@irsmsx110.ger.corp.intel.com> References: <20190111174134.39772-1-reshma.pattan@intel.com> <3007842.nGy45PVQPd@xps> <3AEA2BF9852C6F48A459DA490692831F2A4009E2@irsmsx110.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] pdump: fix vdev cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 10:10:40 -0000 15/01/2019 11:09, Pattan, Reshma: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 11/01/2019 18:51, Reshma Pattan: > > > Virtual devices added in pdump application using rte_eal_hotplug_add > > > should be removed explicitly while existing the pdump application, > > > otherwise the > > > > existing -> exiting ? > > > > > subsequent run of the pdump application will fail with the reason that > > > virtual devices with the same name already exists in primary. > > > > > > Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev > > > attach") > > > CC: stable@dpdk.org > > > CC: ferruh.yigit@intel.com > > > > Why is it marked as a fix of this commit? > > Is it a miss in the conversion from ethdev attach calls? > > Or a changed behaviour with hotplug functions? > > It is changed behaviour with hotplug functions. Please, could you explain?