From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4317A0C45; Fri, 23 Jul 2021 13:52:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 515D440040; Fri, 23 Jul 2021 13:52:19 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 890FC4003C for ; Fri, 23 Jul 2021 13:52:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F2C0D5C00CF; Fri, 23 Jul 2021 07:52:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 23 Jul 2021 07:52:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= t35drxyIyQ2OHqJBRv6JCbiqaWHa/IxIDbvwPBo7chM=; b=GUL8/O5a2M5pjbYW KVzRHd0cd8kjVKxj5SR82cMA7DeiZidiBcdZdLWXpQcJb6V6XeUvMECtOeTQ+yDV lqwF8MUZfYthL2MWgfXb76y41V42i2XR+/MIfpV4PRc6Mk3Cd0bkM42CGgUvedbm y63ZRdappP3265TON6mBi3uQSyo5JoyOkPxKVBzNqBzT4DHoXmWBT/AbASGu0AY4 xMSNGb3vCcbM67bsh/BMN4Q2F3SDRSABRTIEKmyC8QW4qxhKUMY0xP78RgcVvu91 GFYuldkNREC64rl+DYeRlAuQhThH3aydRreI+G/pp9CU2lBUjJLlOwvq938//oux jglANA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=t35drxyIyQ2OHqJBRv6JCbiqaWHa/IxIDbvwPBo7c hM=; b=f9DystXd9yIyXsg4nCU+hSzWp0k+ZiWNevcen2MCMW0UY+uLfX5sGvQDr +6MEp59zGuA++ojO6vKJvhF9YKUveXzIrsTvWfEBpt77L39CxaG96jHr+oS8omPf j6GV0vYQWAvkq2VK/mHXv4pBE/7f6oNkYFQyKAkyI0VGtPWpXgfV4bOKsHjBnMz1 UkPwbMKks2JOsVBAGuvcdxnLOVdTXWErZtnsIiJePUQko/+L1FtrxrtqjZEyL6rQ 58BvlfQoUJ76Xr2Kh5fQS/zmbJT/4IKJs2VfSGaPb9nci5fWTxusuQMEmINefI0L prURsOKpvv6Ag0Cn3cjWbzHyZ1rIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeekgdeghecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeekteehtdeivefhieegjeelgedufeejheekkeetueevieeuvdevuedt jeevheevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Jul 2021 07:52:15 -0400 (EDT) From: Thomas Monjalon To: =?utf-8?B?TWljaGHFgg==?= Krawczyk Cc: dev , "Dagan, Noam" , "Brandes, Shai" , upstream@semihalf.com, Shay Agroskin , Amit Bernstein , Ferruh Yigit , David Marchand Date: Fri, 23 Jul 2021 13:52:35 +0200 Message-ID: <1861470.fCPsIMDXia@thomas> In-Reply-To: References: <20210714103435.3388-1-mk@semihalf.com> <4131521.qjy5Xc5Wae@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 5/6] net/ena: rework RSS configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/07/2021 11:49, Micha=C5=82 Krawczyk: > pt., 23 lip 2021 o 11:43 Thomas Monjalon napisa=C5= =82(a): > > > > 23/07/2021 11:39, Micha=C5=82 Krawczyk: > > > pt., 23 lip 2021 o 11:22 Thomas Monjalon napisa= =C5=82(a): > > > > > > > > 14/07/2021 12:43, Michal Krawczyk: > > > > > + PMD_DRV_LOG(WARNING, > > > > > + "Setting RSS hash fields is not supported= =2E Using default values: 0x%llx\n", > > > > > + ENA_ALL_RSS_HF); > > > > > > > > > > > > > checkpatch is returning this warning: > > > > Using %l format, prefer %PRI*64 if type is [u]int64_t > > > > > > > > Indeed rss_hf is uint64_t. > > > > > > > > > > > > > > Hi Thomas, > > > > > > I'm aware of that checkpatch warning, but changing format to %PRIx64 > > > results in another (compilation) warning: > > > > > > [1205/2572] Compiling C object > > > drivers/libtmp_rte_net_ena.a.p/net_ena_ena_rss.c.o > > > In file included from ../drivers/net/ena/ena_rss.c:7: > > > ../drivers/net/ena/ena_rss.c: In function =E2=80=98ena_rss_hash_set= =E2=80=99: > > > ../drivers/net/ena/ena_logs.h:35:3: warning: format =E2=80=98%lx=E2= =80=99 expects > > > argument of type =E2=80=98long unsigned int=E2=80=99, but argument 5 = has type =E2=80=98long > > > long unsigned int=E2=80=99 [-Wformat=3D] > > > 35 | "%s(): " fmt, __func__, ## args) > > > | ^~~~~~~~ > > > ../drivers/net/ena/ena_rss.c:427:3: note: in expansion of macro =E2= =80=98PMD_DRV_LOG=E2=80=99 > > > 427 | PMD_DRV_LOG(WARNING, > > > | ^~~~~~~~~~~ > > > In file included from ../lib/mempool/rte_mempool.h:40, > > > from ../lib/mbuf/rte_mbuf.h:38, > > > from ../lib/net/rte_ether.h:23, > > > from ../drivers/net/ena/ena_ethdev.h:10, > > > from ../drivers/net/ena/ena_rss.c:6: > > > /usr/include/inttypes.h:121:34: note: format string is defined here > > > 121 | # define PRIx64 __PRI64_PREFIX "x" > > > > > > Sorry I don't have time to dig, but I'm sure you can fix it. > > > > >=20 > Yeah, sure, casting ENA_RSS_HF to uint64_t in this log should do the > trick - I'll fix that in the v4. I think you should declare ENA_RSS_HF with UINT64_C()