From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB0FFA0A0A; Tue, 23 Mar 2021 19:41:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86A9C40683; Tue, 23 Mar 2021 19:41:56 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id EC8E24014D for ; Tue, 23 Mar 2021 19:41:54 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 68467102D; Tue, 23 Mar 2021 14:41:53 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 23 Mar 2021 14:41:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 4oXaaOgYXCgFmor1Z98GJvojPzBZUlEUp7cbbfChi5c=; b=vBD+xpcI9T7WGjiG 6ixDuymX4Gly+TDNQq4Uqt+flYi6t4Z73DZduyQ7qpyWv1pmDcClaIGgeqpIHSeG yIhsiOTNV80GTCDv3/5au3hWZ14zheqjhCPxEK5C/i2rAnAAVYgsaCUzPbrpIfaN jVylZ2hqQNTscVXyp/jNrEiw0WwJ140uJPe/hGiIYXTYP1Ntu4sdGSpojFELb59H hkyf0fz6eRMYnsUO2SThKxIhHFP7uV+sU0pQl8swDXO14JUt/STYRnfcJJQ/YOXO I6/yjVrstIWOvohw44F83L3f83n6d3voDS8oYvVrQUi/CFnS6f1AHlYpcey6OCPT EYaaDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=4oXaaOgYXCgFmor1Z98GJvojPzBZUlEUp7cbbfChi 5c=; b=so2OTaqd4nMmDefl2KArAjLnRhj4zHmIBkCNSUjVX4bXMML4tetyFr7Ng OQgwsieh1EYIaaPue1yLMrHG2cZs0NavkO6qunMVw2PY76NKUFEpaJKIW7PqB9iD hodg7bVsVUm41QQHhdnfqp+aim81wp/nL+OVw3QBK9DP2QEG7ZCseMb7g5dJRECv xWKdjzdcSl/w0UMgzWC6C2EtzbZ6JfTNHRwut1j9Fm79EJB6wGnpvdU4dswST/KW iA3ep6vaPoIHVyFF1hFHYeIPv7xmRM/jITJmw3muk+MWmTpSGXNJ19uHuZKC56Oy jD69YPK/Rqx1aZTR07MiEQdAotgRg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudegiedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 279541080063; Tue, 23 Mar 2021 14:41:51 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Andrew Rybchenko , Ray Kinsella Date: Tue, 23 Mar 2021 19:41:49 +0100 Message-ID: <18618477.ONbPRNMBfW@thomas> In-Reply-To: References: <20210309233116.1934666-1-thomas@monjalon.net> <7775971.yr5XXRrMVS@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/03/2021 19:18, David Marchand: > On Tue, Mar 23, 2021 at 4:10 PM Thomas Monjalon wrote: > > 23/03/2021 14:37, David Marchand: > > > On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon wrote: > > > > > > > > The option --log-level was not completely described in the usage text, > > > > and it was difficult to guess the names of the log types and levels. > > > > > > > > A new value "help" is accepted after --log-level to give more details > > > > about the syntax and listing the log types and levels. > > > > > > > > The array "levels" used for level name parsing is replaced with > > > > a (modified) existing function which was used in rte_log_dump(). > > > > > > If we forget about the slightly different formatting, why not simply > > > reuse rte_log_dump? > > > It has the advantage of listing the default level for each logtype > > > that a user cannot guess otherwise. > > > > I considered rte_log_dump() too much verbose for the help text. > > It is printing the global level and the logtype ids. > > Yes, it gives all the info about the log subsystem. > > > The need for the end-user in the help is different of a debug dump. > > The result of rte_log_list_types is a list in link-time order. > At least it is worth sorting alphabetically for users. Yes sorting could be nice. > What about default log levels? No strong opinion. The default is more or less always the same. If you believe it helps the user, then OK to add default levels.