From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: announce ethdev CRC strip flag deprecation
Date: Tue, 20 Mar 2018 12:35:27 +0100 [thread overview]
Message-ID: <1863259.sHUX8Jkyl1@xps> (raw)
In-Reply-To: <20180320112631.107105-1-ferruh.yigit@intel.com>
20/03/2018 12:26, Ferruh Yigit:
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> +* ethdev: Make CRC stript default behavior without any flag required and add a
s/stript/stripping/
> + new offload flag to let application request for keeping CRC if PMD reports
> + capability for it.
> + ``DEV_RX_OFFLOAD_CRC_STRIP`` flag will be removed.
> + ``DEV_RX_OFFLOAD_KEETP_CRC`` will be added.
s/KEETP/KEEP/
I think we should introduce the new flag without removing the old one
for one release.
Setting both flags would be an error.
Setting no flag would mean stripping.
So the CRC_STRIP flag would be just ignored by PMDs.
Opinions?
next prev parent reply other threads:[~2018-03-20 11:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 11:26 Ferruh Yigit
2018-03-20 11:35 ` Thomas Monjalon [this message]
2018-03-20 17:23 ` Ferruh Yigit
2018-03-21 19:47 ` [dpdk-dev] [PATCH v2 1/2] " Ferruh Yigit
2018-03-21 19:47 ` [dpdk-dev] [PATCH v2 2/2] ethdev: add new offload flag to keep CRC Ferruh Yigit
2018-03-21 21:05 ` Thomas Monjalon
2018-03-29 5:38 ` Shahaf Shuler
2018-03-29 7:43 ` Thomas Monjalon
2018-03-29 7:56 ` Shahaf Shuler
2018-03-29 13:32 ` Ferruh Yigit
2018-04-01 7:10 ` Shahaf Shuler
2018-04-16 17:23 ` Ferruh Yigit
2018-04-16 22:13 ` Thomas Monjalon
2018-04-17 13:12 ` [dpdk-dev] [PATCH v3] doc: announce ethdev CRC strip flag deprecation Ferruh Yigit
2018-04-17 13:31 ` Andrew Rybchenko
2018-04-17 13:36 ` Ferruh Yigit
2018-04-17 13:39 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2018-04-17 13:47 ` Shahaf Shuler
2018-05-28 1:05 ` Thomas Monjalon
2018-08-01 15:27 ` Maxime Coquelin
2018-08-02 8:50 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1863259.sHUX8Jkyl1@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).