From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B01835F19
 for <dev@dpdk.org>; Tue, 20 Mar 2018 12:45:23 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 2F27120701;
 Tue, 20 Mar 2018 07:45:23 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Tue, 20 Mar 2018 07:45:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=jjI9qcEtqRdAKwM6IqaikbpTM1
 pWZj66GCci1vyHiv8=; b=NK6EvuLDj496D6AzVL9nLbeEJ8cCQZku2i65Jh4piV
 Ksrr/gMs3qhNSUTYF4IwVmJGZ87ikjPWfplnU0sAW9qbnX7ZCKKci3mXWFNWl7G6
 sKSTtH+bxpkd17SNxT8rr6dGEcC2rMjEJXNLNWM86OvXobDnXHy0S0w0Ljc+8GLc
 0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jjI9qc
 EtqRdAKwM6IqaikbpTM1pWZj66GCci1vyHiv8=; b=KN41CJUWe5B/lRhfmmJS6T
 l9bw21hEzxqUzx/ewf1npWsHDpjRE9qkoqcoQxo3Rnaq/Bc+LqLJu2tAyPY0MTLQ
 gZz+2zdpXZh7l+rtLSNMk1r9o09s6QcW/XYQZod68jN3vxP1LmGRx0+XKjLr/SVR
 MCF6U3o7l6OoTtn46zQBWCDrX9ytcyhZxNEaWbE6P5vrrUy1veeWuEN6J4NJXq6U
 9KdkHo4Lfm/7D6KdMUC60bNCThGnjHZJYnmijuBC3Tbw0IfU5kMOspPAiV7EVbBE
 suhONC9YfMsHIL5XbNI0MDf11uc3JquLJHMM3eHh0H5v7XZEd0CxeUlWH0mOGI2w
 ==
X-ME-Sender: <xms:U_SwWpzLtt8mKr_z24Tn9OX7ON3G37sc2RMubCwOD_GvkRnhoWg8Xg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 7D74524149;
 Tue, 20 Mar 2018 07:45:22 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Neil Horman <nhorman@tuxdriver.com>,
 John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Date: Tue, 20 Mar 2018 12:35:27 +0100
Message-ID: <1863259.sHUX8Jkyl1@xps>
In-Reply-To: <20180320112631.107105-1-ferruh.yigit@intel.com>
References: <20180320112631.107105-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] doc: announce ethdev CRC strip flag
	deprecation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2018 11:45:23 -0000

20/03/2018 12:26, Ferruh Yigit:
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> +* ethdev: Make CRC stript default behavior without any flag required and add a

s/stript/stripping/

> +  new offload flag to let application request for keeping CRC if PMD reports
> +  capability for it.
> +  ``DEV_RX_OFFLOAD_CRC_STRIP`` flag will be removed.
> +  ``DEV_RX_OFFLOAD_KEETP_CRC`` will be added.

s/KEETP/KEEP/

I think we should introduce the new flag without removing the old one
for one release.
Setting both flags would be an error.
Setting no flag would mean stripping.
So the CRC_STRIP flag would be just ignored by PMDs.

Opinions?