From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 983531DB8 for ; Mon, 8 Oct 2018 10:09:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3139221FAC; Mon, 8 Oct 2018 04:09:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 08 Oct 2018 04:09:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SFkI15YDF0tCi45EPiBXmfg3xa9RdR4pYNMBQvEqzVY=; b=Uu+zJWgVH36h hGrR3Qm/zQ3r7RgHu5sJHmqvLFnZj2x4gbWWK5lqAJBrwleyhHQbV3PtTsauGHSY AQBQbKuO6gj/RQHpKWoUYt1DENxQf0fCGRzlEkNWHY1KEulOKufpij5xrUkJdVBM D7QBi9jEsCXFxjnoks8PuTMZaunw0Sk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=SFkI15YDF0tCi45EPiBXmfg3xa9RdR4pYNMBQvEqz VY=; b=fLNSR/a+oES+/iXrpo7I6FbMzJZca04a6E+Lkqe4IKBhjm1noQsScEKVB VIwnSY7V4vUsEu23mGJ8Jwfwm7v/gmZ+H9lT+DFxaKLCW8BB+32VsclhcFbTd+y6 XPcuMrgH770CgEaK1P2z2YosKoUyf3XTkwWIBpS3GVo1PWR+g47xuSON4YQDlyyp W3tFrvadztrKptJBYmR3iuBgFAh4doLH0PX12w/JmgXrqsnIGNFRe/c7w3x77Pna kel4cLIBduPwUFJn8F9NQ9XtLfQQ7KjBrhqLswjUmAyJTQqmYkoP4+Gw2I0tt2Dz +KN8Hg47tXhzroI4S4tfXtaFEg1YA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D0724E4307; Mon, 8 Oct 2018 04:09:38 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com Date: Mon, 08 Oct 2018 10:09:37 +0200 Message-ID: <1865202.XHyyUIMSdK@xps> In-Reply-To: References: <20181007222554.4886-1-thomas@monjalon.net> <20181007222554.4886-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/5] ethdev: remove deprecated attach/detach functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 08:09:40 -0000 08/10/2018 09:28, Andrew Rybchenko: > On 10/8/18 1:25 AM, Thomas Monjalon wrote: > > The hotplug attach/detach features are implemented in EAL layer. > > There is a new ethdev iterator to retrieve ports from ethdev layer. > > > > As announced earlier, the (buggy) ethdev functions are now removed. > > > > Signed-off-by: Thomas Monjalon > > <...> > > > diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst > > index 097575ad7..063c8b6c4 100644 > > --- a/doc/guides/contributing/documentation.rst > > +++ b/doc/guides/contributing/documentation.rst > > @@ -615,19 +615,14 @@ The following are some guidelines for use of Doxygen in the DPDK API documentati > > .. code-block:: c > > > > /** > > - * Attach a new Ethernet device specified by arguments. > > - * > > - * @param devargs > > - * A pointer to a strings array describing the new device > > - * to be attached. The strings should be a pci address like > > - * `0000:01:00.0` or **virtual** device name like `net_pcap0`. > > - * @param port_id > > - * A pointer to a port identifier actually attached. > > + * Try to take the lock. > > * > > + * @param sl > > + * A pointer to the spinlock. > > * @return > > - * 0 on success and port_id is filled, negative on error. > > + * 1 if the lock is successfully taken; 0 otherwise. > > */ > > - int rte_eth_dev_attach(const char *devargs, uint8_t *port_id); > > + int rte_spinlock_trylock (rte_spinlock_t *sl); > > > > * Doxygen supports Markdown style syntax such as bold, italics, fixed width text and lists. > > For example the second line in the ``devargs`` parameter in the previous example will be rendered as: > > I think it would be better if the hunk goes separately. > It is really confusing in the changeset. OK