From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DC93A0562; Wed, 14 Apr 2021 11:31:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE9411618E3; Wed, 14 Apr 2021 11:31:08 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 7E62B1618DD for ; Wed, 14 Apr 2021 11:31:07 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id ABE0D5803B4; Wed, 14 Apr 2021 05:31:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 14 Apr 2021 05:31:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= OtldT10iDvFBUu7VO571S/vn+OxbtIz+mg8UiMrd5E8=; b=HMt69xy+ddI8mrKN 6/ehKTGmsGTXAwAxIut1TRr+EdMAj5uB23shj6qOJLw5je5B9ITT6qQC8anZJHBT Nee+ZQ6xptGyalfte8NI5PnrGWjsnC65mHT4Jh8dQ1K7hI/EqtZS88kS+0vGPSfc MuZHM3EZA91hjuut3QiRSoNoQAOFQd3P/JS3O1eo2+BHAmwDfzVyGfwCJ1B/uPYd zAk7CRDUkYqaREfAi5qgCik84Q1LD2EYTkXVJoceESzLPkvEkJ38fCZIbvfECjrc y5HjPLzb/R5A2HCfKIQImE1hvoFX+LssE+u9TeCUrayv4gGiHPvhUGMQx1iMaJtv WpDfsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=OtldT10iDvFBUu7VO571S/vn+OxbtIz+mg8UiMrd5 E8=; b=stJ/Ak4rJO3onZQUOobwtAAPfgc5AXZ0PY6ARXYXyGvStF2SysuvU/9ky 6or309sjXGv0y/LvzinpqD8sNhYn0nbL5Qjy1aLj3v9u/xSJI2AsIJQWgG+HSOmo rpFa3+c7vgz1YOH7QxMen73tOQnqks9zB25UX84F8Ry3Xs1Vg4BhGEyvDGXq4/J4 DnFUePIC17lTqWs0JLFy+0GP3rGPRCR5VTn2Em4woFomdchxGEatnOtoE/BQwvsP EVvuRiajK44VTNUkFnFr99UK2A5VoeY6XWseL9LcD5meyZvVd93C3FpWdqsEXxly 4ka0wBgrEzzZ1xu2BR7T2WwYlVD0w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepheelffdtieefgedvjeduudefgedvfeeiledvteehfeefhffguedv vdeffeettdegnecuffhomhgrihhnpehrshhtrdhishenucfkphepjeejrddufeegrddvtd efrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 72AAB24005B; Wed, 14 Apr 2021 05:31:03 -0400 (EDT) From: Thomas Monjalon To: Ori Kam , Haifei Luo Cc: "dev@dpdk.org" , Slava Ovsiienko , Raslan Darawsheh , "Xueming(Steven) Li" , "ajit.khaparde@broadcom.com" , Xiaoyun Li , Matan Azrad , Shahaf Shuler , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Ferruh Yigit , Andrew Rybchenko Date: Wed, 14 Apr 2021 11:31:01 +0200 Message-ID: <1865699.AFZZIqutjf@thomas> In-Reply-To: References: <1615277716-64404-1-git-send-email-haifeil@nvidia.com> <17036885.Jqfv5cWjOq@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/3] ethdev: modify rte API for single flow dump X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2021 11:07, Haifei Luo: > Hi Thomas, > I will remove it from prog_guide/rte_flow.rst. Is it okay ? Thank you. This is more a question for Ori. In case he is not available, yes I think it is better to skip rte_flow.rst in this patch as it doesn't bring added value. Note: please avoid top-post. > From: Thomas Monjalon > 14/04/2021 10:41, Haifei Luo: > > Previous implementations support dump all the flows. Add new arg > > rte_flow in rte_flow_dev_dump to dump one flow. > > > > Signed-off-by: Haifei Luo > > Acked-by: Ajit Khaparde > > Acked-by: Ori Kam > [...] > > +Dump > > +~~~~~ > > + > > +Dump information for all or one flows. > > + > > +.. code-block:: c > > + > > + int > > + rte_flow_dev_dump(uint16_t port_id, struct rte_flow *flow, > > + FILE *file, > > + struct rte_flow_error *error); > > + > > +Arguments: > > + > > +- ``port_id``: port identifier of Ethernet device. > > +- ``flow``: flow rule handle to dump. NULL to dump all. > > +- ``file``: a pointer to a file for output > > +- ``error``: perform verbose error reporting if not NULL. PMDs > > +initialize > > + this structure in case of error only. > > + > > +Return values: > > + > > +- 0 on success, a negative errno value otherwise and ``rte_errno`` is set. > > I really don't understand why we continue duplicating rte_flow doxygen in the guide. Please stop. > Do one good API description in doxygen, > and describe only the big picture and how-to in the guide.