From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 62E267CFC for ; Fri, 30 Mar 2018 17:40:41 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B60CA21249; Fri, 30 Mar 2018 11:40:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 30 Mar 2018 11:40:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nnULspomYZJlTGqhRXRfIiNtxO A1zt6X+VuwrlseGi4=; b=AccOQNuoZUi2PysdbhQdd4cKkE/QSTSg0j7xevGfMP 701Gzl/GpZiS3Gqlfj9dBNbbtTps5CEW5s19MEgIccDh4iukuBY/KXm+0b1rUuLl aHOYQGIp3z6DZMiROItCiQuTzDXnxLc869Xusy02mvWVYpAwwS3MjWL62fjqj5M0 c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=nnULsp omYZJlTGqhRXRfIiNtxOA1zt6X+VuwrlseGi4=; b=FWlTil3AAj02l3qksIZMPd OYqJbvQXIYQLVDmk8ygVCD5LYrmwLb2uhNhmkR58n21mE4MY134gdzuZL1M6jV+Y GcP5q0b89z2MecVyKo7NsyskeVt89Q0JGG+r2UgQZTa/eToVAX1fjTdW0T1pSdgI 6vF2MsnukcxI3viJlqDtB7vV9nM55fuLpZ4y8q5m2dFxyB1puifNJXWTz3kTooHx 9zaGD9WJ0y8PwdUlKasutWAEnn+Obo+0ZzD4DRbFiPRidFUGn5yKdWiIeleJZQBW cAxKbdI3sWHU9i/yj33lbZ2Iza88aSYrRunq9Gi31l44Qp6U4shdB72NHnpfisLA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6A86CE5084; Fri, 30 Mar 2018 11:40:39 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org, John McNamara , Wenzhuo Lu , Jingjing Wu , Qi Zhang , Beilei Xing , Shreyansh Jain , ferruh.yigit@intel.com Date: Fri, 30 Mar 2018 17:40:08 +0200 Message-ID: <1867154.rqMg12d5dS@xps> In-Reply-To: <20180321142749.27520-2-remy.horton@intel.com> References: <20180321142749.27520-1-remy.horton@intel.com> <20180321142749.27520-2-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 15:40:41 -0000 I know that this patch is already applied, but I have some comments below. Please try to address them. 21/03/2018 15:27, Remy Horton: > + /* If number of queues specified by application for both Rx and Tx is > + * zero, use driver preferred values. This cannot be done individually > + * as it is valid for either Tx or Rx (but not both) to be zero. > + * If driver does not provide any preferred valued, fall back on > + * EAL defaults. > + */ The fallback could be set in rte_eth_dev_info_get() and call this function instead of calling directly dev_ops->dev_infos_get. It would require to never return -ENOTSUP. At least, some default values should be set in rte_eth_dev_info_get(). > @@ -1029,6 +1048,10 @@ struct rte_eth_dev_info { > /** Configured number of rx/tx queues */ > uint16_t nb_rx_queues; /**< Number of RX queues. */ > uint16_t nb_tx_queues; /**< Number of TX queues. */ > + > + /** Tx/Rx parameter recommendations */ > + struct rte_eth_dev_portconf default_rxportconf; > + struct rte_eth_dev_portconf default_txportconf; Some formatting comments: Usually, there is no blank line in structs. The doxygen comment must apply to each field. Have you checked what is the doxygen output?